Pkg xen devel - Jan 2016 - Bug#812166: xen: FTBFS with GCC 6: statement is indented as if...

Package: xen
Version: 4.6.0-1
Severity: important
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-6 gcc-6-misleading-indentation

This package fails to build with GCC 6.  GCC 6 has not been released
yet, but it's expected that GCC 6 will become the default compiler for
stretch.

Note that only the first error is reported; there might be more.  You
can find a snapshot of GCC 6 in experimental.  To build with GCC 6,
you can set CC=gcc-6 CXX=g++-6 explicitly.

You may be able to find out more about this issue at
https://gcc.gnu.org/gcc-6/changes.html
> sbuild (Debian sbuild) 0.67.0 (26 Dec 2015) on dl580gen9-02.hlinux
...
> gcc -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall
-Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable
-Wno-unused-local-typedefs   -DNDEBUG
-I/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/include
-I/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/include/asm-x86/mach-generic
-I/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/include/asm-x86/mach-default
-msoft-float -fno-stack-protector -fno-exceptions -Wnested-externs
-DHAVE_GAS_VMX -DHAVE_GAS_EPT -DHAVE_GAS_FSGSBASE -mno-red-zone -mno-sse -fpic
-fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -fno-builtin
-fno-common -Werror -Wredundant-decls -Wno-pointer-arith -pipe -g -D__XEN__
-include
/<<PKGBUILDDIR>>/debian/build/build-hypervisor_amd64_amd64/xen/include/xen/config.h
-nostdinc -DCONFIG_SHADOW_PAGING -DHAS_ACPI -DHAS_GDBSX -DHAS_PASSTHROUGH
-DHAS_MEM_ACCESS -DHAS_MEM_PAGING -DHAS_MEM_SHARING -DHAS_PCI -DHAS_IOPORT
> S -DHAS_PDX -MMD -MF .non-fatal.o.d -c non-fatal.c -o non-fatal.o
> non-fatal.c: In function 'init_nonfatal_mce_checker':
> non-fatal.c:103:2: error: statement is indented as if it were guarded by...
[-Werror=misleading-indentation]
>   switch (c->x86_vendor) {
>   ^~~~~~
> 
> non-fatal.c:97:5: note: ...this 'if' clause, but it is not
>      if ( __get_cpu_var(poll_bankmask) == NULL )
>      ^~
> 
> cc1: all warnings being treated as errors
-- 
Martin Michlmayr
Linux for HPE Helion, Hewlett Packard Enterprise

On Wed, 2016-01-20 at 20:16 -0800, Martin Michlmayr
wrote:
> Package: xen
> Version: 4.6.0-1
> Severity: important
> User: debian-gcc at lists.debian.org
> Usertags: ftbfs-gcc-6 gcc-6-misleading-indentation
> 
> This package fails to build with GCC 6.??GCC 6 has not been released
> yet, but it's expected that GCC 6 will become the default compiler for
> stretch.
> 
> Note that only the first error is reported; there might be more.??You
> can find a snapshot of GCC 6 in experimental.??To build with GCC 6,
> you can set CC=gcc-6 CXX=g++-6 explicitly.
> 
> You may be able to find out more about this issue at
> https://gcc.gnu.org/gcc-6/changes.html
> 
> > sbuild (Debian sbuild) 0.67.0 (26 Dec 2015) on dl580gen9-02.hlinux
> ...
> > gcc -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99
-Wall -Wstrict-prototypes -Wdeclaration-after-statement
-Wno-unused-but-set-variable -Wno-unused-local-typedefs???-DNDEBUG
-I/<>/debian/build/build-hypervisor_amd64_amd64/xen/include??-I/<>/debian/build/build-hypervisor_amd64_amd64/xen/include/asm-x86/mach-generic
-I/<>/debian/build/build-hypervisor_amd64_amd64/xen/include/asm-x86/mach-default
-msoft-float -fno-stack-protector -fno-exceptions -Wnested-externs
-DHAVE_GAS_VMX -DHAVE_GAS_EPT -DHAVE_GAS_FSGSBASE -mno-red-zone -mno-sse -fpic
-fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -fno-builtin
-fno-common -Werror -Wredundant-decls -Wno-pointer-arith -pipe -g -D__XEN__
-include
/<>/debian/build/build-hypervisor_amd64_amd64/xen/include/xen/config.h
-nostdinc -DCONFIG_SHADOW_PAGING -DHAS_ACPI -DHAS_GDBSX -DHAS_PASSTHROUGH
-DHAS_MEM_ACCESS -DHAS_MEM_PAGING -DHAS_MEM_SHARING -DHAS_PCI -DHAS_IOPORT
> > S -DHAS_PDX -MMD -MF .non-fatal.o.d -c non-fatal.c -o non-fatal.o
> > non-fatal.c: In function 'init_nonfatal_mce_checker':
> > non-fatal.c:103:2: error: statement is indented as if it were guarded
by... [-Werror=misleading-indentation]
> > ? switch (c->x86_vendor) {
> > ? ^~~~~~
> > 
> > non-fatal.c:97:5: note: ...this 'if' clause, but it is not
> > ?????if ( __get_cpu_var(poll_bankmask) == NULL )
> > ?????^~
> > 
> > cc1: all warnings being treated as errors
I have rebuilt the upstream xen source (both development version and 4.6)
with gcc-6 from experimental:

$ gcc-6 --version
gcc-6 (Debian 6-20160117-1) 6.0.0 20160117 (experimental) [trunk revision
232481]
Copyright (C) 2016 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.??There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

and did not come across any issues. However looking at non-fatal.c I can
see that the misleading-indentation it is complaining about is still
present.

Neither the upstream build system nor the Debian packaging are enabling
Wmisleading-indentation, so I suspect this has come from somewhere else,
perhaps via gcc or maybe via dh and some hardening thing?

I don't see the warning/error being enabled on the gcc command line in the
log snippet above, so perhaps this was an option enabled in an earlier gcc-
6 snapshot which isn't on now?

Regardless, I'm going to take a look at enabling this warning upstream and
fixing the fallout, since it seems like a good code cleanliness thing to
do.

Ian.

* Ian Campbell <ijc at debian.org> [2016-01-22
12:51]:
> I have rebuilt the upstream xen source (both development version and 4.6)
> with gcc-6 from experimental:
> 
> $ gcc-6 --version
> gcc-6 (Debian 6-20160117-1) 6.0.0 20160117 (experimental) [trunk revision
232481]
> Copyright (C) 2016 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.??There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> 
> and did not come across any issues.
Hmm, strange.  As far as I can tell (based on a really quick look),
various Makefiles define -Werror.  And I see -Wall, too.  -Wall would
pull in the new warning.

Anyway, I guess it doesn't matter since you're fixing the code
indentation anyway.

-- 
Martin Michlmayr
Linux for HPE Helion, Hewlett Packard Enterprise

Processing control commands:
> fixed 812166 4.8.0~rc3-0exp1
Bug #812166 [xen] xen: FTBFS with GCC 6: statement is indented as if...
There is no source info for the package 'xen' at version
'4.8.0~rc3-0exp1' with architecture ''
Unable to make a source version for version '4.8.0~rc3-0exp1'
Ignoring request to alter fixed versions of bug #812166 to the same values
previously set
> fixed 812166 4.8.0~rc5-1
Bug #812166 [xen] xen: FTBFS with GCC 6: statement is indented as if...
There is no source info for the package 'xen' at version
'4.8.0~rc5-1' with architecture ''
Unable to make a source version for version '4.8.0~rc5-1'
Ignoring request to alter fixed versions of bug #812166 to the same values
previously set
> unblock 827061 by 812166
Bug #827061 [release.debian.org] transition: openssl
827061 was blocked by: 828321 828263 828513 828455 828291 829452 828569 828315
828240 828562 828400 828269 828429 828332 828518 828426 828242 809271 828594
828420 835793 828411 828413 828346 828331 828609 828320 828471 828327 828258
828512 827076 828239 828591 828548 828410 828449 828271 828579 828576 828551
828608 828490 828305 828465 828460 828559 828603 828529 828614 828414 828541
828507 828297 828613 828421 828349 828593 828605 828588 828493 828538 828502
828402 829465 828431 828485 828415 828284 828261 841635 828424 828333 828295
828364 828521 828322 828383 828303 828292 828442 828280 828243 828506 828610
828545 828530 828523 828498 828266 828500 828314 828283 828127 828371 828300
828505 828577 828459 835811 828328 828488 828348 835796 844301 828467 828466
828290 828554 835797 828427 828550 828430 828516 828237 828443 828394 828556
828265 827068 828492 828302 828546 828404 828310 828388 828477 828462 828380
828298 828565 828536 828432 828345 835785 828389 828585 828446 828288 828491
828463 828549 828543 828369 828252 828401 828504 828570 844311 828461 828406
828566 828480 828395 828313 828601 828532 828558 828511 828379 828419 828547
828317 828615 828412 828533 828457 828439 828517 828510 828574 828522 828482
835799 828234 828405 843532 828599 828325 828553 828520 828484 828595 828450
828440 828525 828370 828387 828469 828552 828564 828535 828285 828232 828508
828539 828343 828436 828344 828359 828499 828373 828557 828607 835800 828602
828619 828277 828540 828578 828563 828581 828590 828246 828597 828437 835789
828617 828489 828340 828456 828392 828586 828259 828494 828422 828384 828367
828375 828281 828501 828481 828514 828241 828342 828572 828083 828582 836419
828376 828307 828276 828438 828441 828592 828409 828248 828249 828487 835798
828612 828286 828255 828256 828417 828366 835790 828329 828447 844254 828403
828407 828372 828323 828451 828318 828308 835549 828229 828228 828287 828363
828253 828296 828360 828304 828250 828495 828335 835804 828233 828416 828294
828235 828254 828238 828620 828260 828567 828336 828272 844345 828600 828268
828339 828278 828571 828293 828301 828385 828289 828316 828082 828464 828445
828425 835794 822380 828580 828324 835786 828357 828397 828262 828139 828434
828604 828524 828468 828330 828282 828503 828354 828312 828472 828279 837960
828334 828351 828478 828428 828423 844271 828257 828347 828618 828458 828338
828542 828583 828483 828381 828454 828555 828355 828519 828390 828452 828531
844347 828365 843988 828587 828418 828267 828486 828396 828362 828319 828251
828350 828433 828270 828589 828274 828352 828470 828393 828391 828244 828435
828561 828374 828382 828377 828306 828496 828142 828444 828611 828473 828537
828356 835585 828398 828231 828584 808669 828358 828526 828534 828596 828341
814600 828399 828616 828573 828264 828527 828575 828275 828509 828245 828453
828474 828544 828337 828361 828528 828568 828386 828368 828230 828479 828273
828497 828448 828598 828326 828378 828476 828515 828606 828560 828309 828353
828311
827061 was not blocking any bugs.
Removed blocking bug(s) of 827061: 812166
> clone 812166 -2
Bug #812166 [xen] xen: FTBFS with GCC 6: statement is indented as if...
Bug 812166 cloned as bug 844419
> retitle -2 consider dropping libssl-dev build-dep
Bug #844419 [xen] xen: FTBFS with GCC 6: statement is indented as if...
Changed Bug title to 'consider dropping libssl-dev build-dep' from
'xen: FTBFS with GCC 6: statement is indented as
if...'.
> severity -2 normal
Bug #844419 [xen] consider dropping libssl-dev build-dep
Severity set to 'normal' from 'serious'

-- 
812166: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812166
827061: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=827061
844419: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=844419
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems

Your message dated Tue, 15 Nov 2016 15:38:28 +0000
with message-id <22571.11252.131395.33666 at mariner.uk.xensource.com>
and subject line Fixed by new upstream version
has caused the Debian Bug report #812166,
regarding xen: FTBFS with GCC 6: statement is indented as if...
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
812166: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812166
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Martin Michlmayr <tbm at hpe.com>
Subject: xen: FTBFS with GCC 6: statement is indented as if...
Date: Wed, 20 Jan 2016 20:16:22 -0800
Size: 4213
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20161115/1eb54b23/attachment.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: Ian Jackson <ian.jackson at eu.citrix.com>
Subject: Fixed by new upstream version
Date: Tue, 15 Nov 2016 15:38:28 +0000
Size: 1660
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20161115/1eb54b23/attachment-0001.mht>

Your message dated Thu, 22 Dec 2016 18:49:44 +0000
with message-id <E1cK8Qy-0003nP-Fu at fasolo.debian.org>
and subject line Bug#812166: fixed in xen 4.8.0-1
has caused the Debian Bug report #812166,
regarding xen: FTBFS with GCC 6: statement is indented as if...
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
812166: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812166
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Martin Michlmayr <tbm at hpe.com>
Subject: xen: FTBFS with GCC 6: statement is indented as if...
Date: Wed, 20 Jan 2016 20:16:22 -0800
Size: 4213
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20161222/d1ccea6d/attachment.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: Ian Jackson <ian.jackson at eu.citrix.com>
Subject: Bug#812166: fixed in xen 4.8.0-1
Date: Thu, 22 Dec 2016 18:49:44 +0000
Size: 11301
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20161222/d1ccea6d/attachment-0001.mht>

Your message dated Thu, 22 Dec 2016 18:49:44 +0000
with message-id <E1cK8Qy-0003nk-Id at fasolo.debian.org>
and subject line Bug#844419: fixed in xen 4.8.0-1
has caused the Debian Bug report #844419,
regarding consider dropping libssl-dev build-dep
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
844419: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=844419
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Martin Michlmayr <tbm at hpe.com>
Subject: xen: FTBFS with GCC 6: statement is indented as if...
Date: Wed, 20 Jan 2016 20:16:22 -0800
Size: 4213
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20161222/9b7a8bca/attachment-0002.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: Ian Jackson <ian.jackson at eu.citrix.com>
Subject: Bug#844419: fixed in xen 4.8.0-1
Date: Thu, 22 Dec 2016 18:49:44 +0000
Size: 11301
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20161222/9b7a8bca/attachment-0003.mht>

Your message dated Wed, 23 Jan 2019 22:49:44 +0100
with message-id <5c76156e-c00d-8803-e431-2d986ed734e3 at knorrie.org>
and subject line Re: consider dropping libssl-dev build-dep
has caused the Debian Bug report #844417,
regarding consider dropping libssl-dev build-dep
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
844417: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=844417
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Martin Michlmayr <tbm at hpe.com>
Subject: xen: FTBFS with GCC 6: statement is indented as if...
Date: Wed, 20 Jan 2016 20:16:22 -0800
Size: 4213
URL:
<http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20190123/3016307d/attachment.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: Hans van Kranenburg <hans at knorrie.org>
Subject: Re: consider dropping libssl-dev build-dep
Date: Wed, 23 Jan 2019 22:49:44 +0100
Size: 7287
URL:
<http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20190123/3016307d/attachment-0001.mht>