Konrad Rzeszutek Wilk
2014-Dec-03 20:36 UTC
[Pkg-xen-devel] [PATCH for-xen-4.5 1/3] tools/hotplug: distclean target should remove files generated by configure
On Wed, Dec 03, 2014 at 04:53:53PM +0100, Daniel Kiper wrote:> On Tue, Dec 02, 2014 at 01:36:20PM -0500, Konrad Rzeszutek Wilk wrote: > > On Tue, Dec 02, 2014 at 04:16:28PM +0100, Daniel Kiper wrote: > > > Signed-off-by: Daniel Kiper <daniel.kiper at oracle.com> > > > > This usage scenario which I can see this being useful (and > > I've tripped over this) is when you rebuild a new version > > from the same repo. As in, this affects developers, but > > not end-users and not distros. But perhaps I am missing > > one scenario? > > > > As such I would lean towards deferring this (and the other > > two) to Xen 4.6. > > As I know Debian build system sometimes complain if make distclean > does not leave build tree in distclean state (read "state before > configure" != "state after distclean"). It means that from > distros point of view we should apply this patch. However, > other two are not required and we can deffer them to Xen 4.6.Cc-ing Axel and Debian Xen Team.> > Daniel
Ian Campbell
2014-Dec-04 08:17 UTC
[Pkg-xen-devel] [PATCH for-xen-4.5 1/3] tools/hotplug: distclean target should remove files generated by configure
On Wed, 2014-12-03 at 15:36 -0500, Konrad Rzeszutek Wilk wrote:> On Wed, Dec 03, 2014 at 04:53:53PM +0100, Daniel Kiper wrote: > > On Tue, Dec 02, 2014 at 01:36:20PM -0500, Konrad Rzeszutek Wilk wrote: > > > On Tue, Dec 02, 2014 at 04:16:28PM +0100, Daniel Kiper wrote: > > > > Signed-off-by: Daniel Kiper <daniel.kiper at oracle.com> > > > > > > This usage scenario which I can see this being useful (and > > > I've tripped over this) is when you rebuild a new version > > > from the same repo. As in, this affects developers, but > > > not end-users and not distros. But perhaps I am missing > > > one scenario? > > > > > > As such I would lean towards deferring this (and the other > > > two) to Xen 4.6. > > > > As I know Debian build system sometimes complain if make distclean > > does not leave build tree in distclean state (read "state before > > configure" != "state after distclean"). It means that from > > distros point of view we should apply this patch. However, > > other two are not required and we can deffer them to Xen 4.6. > > Cc-ing Axel and Debian Xen Team.Debian is shipping 4.4 in the next release (8, Jessie, already frozen) and I think it likely that the release after that will ship something greater than 4.5 due to the timelines involved. In any case, the Debian Xen packages cannot have any bugs of the kind mentioned here because the package copyies the source to debian/build/foo (for reasons other than distclean) and nuking the entire of debian/build on clean. Ian.
Maybe Matching Threads
- make -DNOCLEANDEPENDS distclean
- git folder moved : waf : The top source directory has moved. Please run distclean and reconfigure
- preparing for 4.2.3 and 4.1.6
- [PATCH] libxenctrl: Fix xc_interface_close() crash if it gets NULL as an argument
- [PATCH] Fix the 'distclean' target.