Pkg xen devel - Mar 2013 - Bug#702046: xen-utils-4.0: PyGrub VM Boot fails after xen-utils 4.0.1-5.6 -> 4.0.1-5.7 Update

Package: xen-utils-4.0
Version: 4.0.1-5.7
Severity: important

After Upgrading to xen-utils 4.0.1-5.7 my pygrub Xen VMs won't boot. Running
pygrub manually shows:

/usr/lib/xen-default/bin/pygrub --args=root="/dev/xvda ro"
--output=/tmp/foo  /dev/vg0/vm-disk
Using <class 'grub.GrubConf.Grub2ConfigFile'> to parse
/boot/grub/grub.cfg
WARNING:root:Unknown directive load_video
WARNING:root:Unknown directive terminal_output
WARNING:root:Unknown directive source
Traceback (most recent call last):
  File "/usr/lib/xen-default/bin/pygrub", line 705, in <module>
    output_directory, not_really)
NameError: name 'output_directory' is not defined

After replacing the new pygrub file with the one from the previous package
everything works as expected.

I looked in the upstream source and this suggests that there should be a:
    output_directory = "/var/run/xend/boot"
    not_really = False
somewhere around L646
If i insert that, it also works as expected.

-- System Information:
Debian Release: 6.0.7
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-xen-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages xen-utils-4.0 depends on:
ii  e2fslibs                1.41.12-4stable1 ext2/ext3/ext4 file system librari
ii  iproute                 20100519-3       networking and traffic control too
ii  libc6                   2.11.3-4         Embedded GNU C Library: Shared lib
ii  libncurses5             5.7+20100313-5   shared libraries for terminal hand
ii  libxenstore3.0          4.0.1-5.7        Xenstore communications library fo
ii  python-support          1.0.10           automated rebuilding support for P
ii  python2.5               2.5.5-11         An interactive high-level object-o
ii  udev                    164-3            /dev/ and hotplug management daemo
ii  xen-utils-common        4.0.0-1          XEN administrative tools - common 
ii  zlib1g                  1:1.2.3.4.dfsg-3 compression library - runtime

Versions of packages xen-utils-4.0 recommends:
ii  bridge-utils                  1.4-5      Utilities for configuring the Linu
ii  xen-hypervisor-4.0-amd64 [xen 4.0.1-5.7  The Xen Hypervisor on AMD64

Versions of packages xen-utils-4.0 suggests:
pn  xen-docs-4.0                  <none>     (no description available)

-- no debconf information

Adding security folks to cc.
On Sat, 2013-03-02 at 08:46 +0100, Sebastian Melchior
wrote:
> Package: xen-utils-4.0
> Version: 4.0.1-5.7
> Severity: important
> 
> After Upgrading to xen-utils 4.0.1-5.7 my pygrub Xen VMs won't boot.
Running pygrub manually shows:
> 
> /usr/lib/xen-default/bin/pygrub --args=root="/dev/xvda ro"
--output=/tmp/foo  /dev/vg0/vm-disk
> Using <class 'grub.GrubConf.Grub2ConfigFile'> to parse
/boot/grub/grub.cfg
> WARNING:root:Unknown directive load_video
> WARNING:root:Unknown directive terminal_output
> WARNING:root:Unknown directive source
> Traceback (most recent call last):
>   File "/usr/lib/xen-default/bin/pygrub", line 705, in
<module>
>     output_directory, not_really)
> NameError: name 'output_directory' is not defined
> 
> After replacing the new pygrub file with the one from the previous package
everything works as expected.
> 
> I looked in the upstream source and this suggests that there should be a:
>     output_directory = "/var/run/xend/boot"
>     not_really = False
> somewhere around L646
> If i insert that, it also works as expected.
The fix for CVE-2012-4544 relies on two previous fixes which were not
backported:
21734:b2a89e9e4630 tools/pygrub: --not-really option for debugging
21796:acd99661ba05 pygrub: introduce easier to parse output format

However I think rather than backporting them the find which Sebastian
has identified, i.e. adding those two definitions, is the more minimal
but just as correct fix.

I've attached a debdiff of what I believe the fix is going to be.
However I'm travelling at the moment and on a slight dodgy Internet link
so testing is taking a little longer than normal. I'll try and report
back ASAP.

Sorry for not properly testing this aspect of the backport in the first
place.

Ian.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xen.debdiff
Type: text/x-patch
Size: 2206 bytes
Desc: not available
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20130302/925d733e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20130302/925d733e/attachment.pgp>

Hello,

many thanks, this bug report and the debdiff helped me to boot a domU after 
the upgrade!


-- 
greetings

eMHa
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20130302/27661b8f/attachment.pgp>

I too was unable to boot domU after the upgrade, and Sebastian's patch
worked perfectly.

All I did was this part:
> I looked in the upstream source and this suggests that there should be a:
>     output_directory = "/var/run/xend/boot"
>     not_really = False
> somewhere around L646
> If i insert that, it also works as expected.
I edited /usr/lib/xen-4.0/bin/pygrub, added this change (line number was
correct, too), and now my system boots again :)

Thanks!

Your message dated Sun, 03 Mar 2013 19:32:04 +0000
with message-id <E1UCEdg-0003z6-R7 at franck.debian.org>
and subject line Bug#702046: fixed in xen 4.0.1-5.8
has caused the Debian Bug report #702046,
regarding xen-utils-4.0: PyGrub VM Boot fails after xen-utils 4.0.1-5.6 ->
4.0.1-5.7 Update
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
702046: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=702046
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Sebastian Melchior <webmaster at mailz.de>
Subject: xen-utils-4.0: PyGrub VM Boot fails after xen-utils 4.0.1-5.6 ->
4.0.1-5.7 Update
Date: Sat, 02 Mar 2013 08:46:31 +0100
Size: 3982
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20130303/1b6dbf50/attachment.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: Ian Campbell <ijc at hellion.org.uk>
Subject: Bug#702046: fixed in xen 4.0.1-5.8
Date: Sun, 03 Mar 2013 19:32:04 +0000
Size: 5797
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20130303/1b6dbf50/attachment-0001.mht>