Pkg xen devel - Jun 2012 - Bug#677244: xen-utils-common: xen-toolstack fails if either `xm` or `xl` is not found in xen-dir

Package: xen-utils-common
Version: 4.1.2-7
Severity: grave
Tags: patch
Justification: renders package unusable

Dear Maintainer,

The script /usr/lib/xen-common/bin/xen-toolstack improperly aborts if *either*
`xm` or `xl` cannot be found in the xen-dir (/usr/lib/xen-4.0/bin).  This means
that a default installation (e.g. following Debian wiki on the subject, namely
installing xen-linux-system and xen-tools without any configuration) will NOT be
usable as-is because it "cannot find an usable toolstack".

This is due to a bug in the error handling of the xen-toolstack script when it
comes to checking the availability of `xm` and `xl`.  Since the script is run
with `sh -e` and the return value of `command -v` isn't used, the script
aborts.

Attached is a tiny patch fixing the issue by using the `command -v` return
value.


Best regards,
Colomban

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500,
'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages xen-utils-common depends on:
ii  gawk            1:4.0.1+dfsg-2
ii  lsb-base        4.1+Debian7
ii  python          2.7.3~rc2-1
ii  ucf             3.0025+nmu3
ii  udev            175-3.1
ii  xenstore-utils  4.1.2-7

xen-utils-common recommends no packages.

xen-utils-common suggests no packages.

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xen-toolstack-check-fix.patch
Type: text/x-diff
Size: 338 bytes
Desc: not available
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20120612/b79f3f8b/attachment.patch>

On Tue, Jun 12, 2012 at 05:42:41PM +0200, Colomban Wendling
wrote:
> The script /usr/lib/xen-common/bin/xen-toolstack improperly aborts if
*either*
> `xm` or `xl` cannot be found in the xen-dir (/usr/lib/xen-4.0/bin).
Current is 4.1, so a default installation is not affected.

Bastian

-- 
Insufficient facts always invite danger.
		-- Spock, "Space Seed", stardate 3141.9

Your message dated Thu, 14 Jun 2012 15:48:51 +0000
with message-id <E1SfCHz-00087c-Ik at franck.debian.org>
and subject line Bug#677244: fixed in xen 4.1.3~rc1+hg-20120614.a9c0a89c08f2-1
has caused the Debian Bug report #677244,
regarding xen-utils-common: xen-toolstack fails if either `xm` or `xl` is not
found in xen-dir
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
677244: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=677244
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Colomban Wendling <lists.ban at herbesfolles.org>
Subject: xen-utils-common: xen-toolstack fails if either `xm` or `xl` is not
found in xen-dir
Date: Tue, 12 Jun 2012 17:42:41 +0200
Size: 3787
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20120614/b4c3bb3c/attachment.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: Bastian Blank <waldi at debian.org>
Subject: Bug#677244: fixed in xen 4.1.3~rc1+hg-20120614.a9c0a89c08f2-1
Date: Thu, 14 Jun 2012 15:48:51 +0000
Size: 11216
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20120614/b4c3bb3c/attachment-0001.mht>