Pkg xen devel - Feb 2012 - Bug#661687: xen-utils-common: TOOLSTACK setting not honored

tags 661687 +patch
thanks

On Thursday 01 March 2012 12:04 AM, Ritesh Raj Sarraf
wrote:
> /etc/default/xen, which carries the TOOLSTACK setting, is not honored by
xend init script.
>
> The xend initscript doesn't check for the value of TOOLSTACK. It just
populates it in its initscript.
>
> lnx200-39:/etc/init.d# grep TOOLSTACK *
> xend:TOOLSTACK=$(/usr/lib/xen-common/bin/xen-toolstack 2>/dev/null)
> xend:   if [ -z "$XEND" ] || [ "$(basename
"$TOOLSTACK")" != xm ]; then
>
Attached patch should fix the problem. Waldi, could you please apply it?
This would also help the XCP stack in easy determination of which stack
is in use. Otherwise, please let me know. I can also commit it. I have
write access to pkg-xen.


Rietsh

-- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System

-------------- next part --------------
A non-text attachment was scrubbed...
Name: xend.patch
Type: text/x-patch
Size: 803 bytes
Desc: not available
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20120229/b87d5be1/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20120229/b87d5be1/attachment.pgp>

Processing commands for control at bugs.debian.org:
> tags 661687 +patch
Bug #661687 [xen-utils-common] xen-utils-common: TOOLSTACK setting not honored
Added tag(s) patch.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
661687: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=661687
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems

Package: xen-utils-common
Version: 4.1.2-3
Severity: important

/etc/default/xen, which carries the TOOLSTACK setting, is not honored by xend
init script.

The xend initscript doesn't check for the value of TOOLSTACK. It just
populates it in its initscript.

lnx200-39:/etc/init.d# grep TOOLSTACK *
xend:TOOLSTACK=$(/usr/lib/xen-common/bin/xen-toolstack 2>/dev/null)
xend:   if [ -z "$XEND" ] || [ "$(basename
"$TOOLSTACK")" != xm ]; then



-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1,
'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-1-amd64 (SMP w/24 CPU cores)
Locale: LANG=en_IN, LC_CTYPE=en_US.UTF-8 (charmap=locale: Cannot set LC_CTYPE to
default locale: No such file or directory
locale: Cannot set LC_MESSAGES to default locale: No such file or directory
locale: Cannot set LC_ALL to default locale: No such file or directory
ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

Versions of packages xen-utils-common depends on:
ii  gawk            1:3.1.8+dfsg-0.1
ii  lsb-base        3.2-28.1
ii  udev            175-3.1
ii  xenstore-utils  4.1.2-3

xen-utils-common recommends no packages.

xen-utils-common suggests no packages.

-- Configuration Files:
/etc/xen/xend-config.sxp changed:
(xend-http-server yes)
(xend-unix-server yes)
(xend-tcp-xmlrpc-server yes)
(xend-unix-xmlrpc-server yes)
(xend-relocation-server yes)
(xend-udev-event-server yes)
(xend-unix-path /var/lib/xend/xend-socket)
(xend-port            8000)
(xend-relocation-port 8002)
(xend-address '')
(xend-relocation-address '')
(xend-relocation-hosts-allow '')
(network-script network-nat)
(vif-script     vif-nat)
(dom0-min-mem 196)
(enable-dom0-ballooning yes)
(total_available_memory 0) 
(dom0-cpus 0)
(vncpasswd '')


-- debconf information:
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = "en_IN:en",
	LC_ALL = (unset),
	LC_TIME = "en_IN.UTF-8",
	LC_MONETARY = "en_IN.UTF-8",
	LC_CTYPE = "en_US.UTF-8",
	LC_COLLATE = "en_US.UTF-8",
	LC_ADDRESS = "en_IN.UTF-8",
	LC_TELEPHONE = "en_IN.UTF-8",
	LC_MESSAGES = "en_US.UTF-8",
	LC_NAME = "en_IN.UTF-8",
	LC_MEASUREMENT = "en_IN.UTF-8",
	LC_NUMERIC = "en_IN.UTF-8",
	LC_PAPER = "en_IN.UTF-8",
	LANG = "en_IN"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
locale: Cannot set LC_CTYPE to default locale: No such file or directory
locale: Cannot set LC_MESSAGES to default locale: No such file or directory
locale: Cannot set LC_ALL to default locale: No such file or directory

On Wed, Feb 29, 2012 at 04:21:52PM +0530, Ritesh Raj Sarraf
wrote:
> -TOOLSTACK=$(/usr/lib/xen-common/bin/xen-toolstack 2>/dev/null)
> -if [ $? -ne 0 ]; then
> -	log_warning_msg "No usable Xen toolstack selected"
> -	exit 0
> +
> +if [ -z $TOOLSTACK ]; then
> +	TOOLSTACK=$(/usr/lib/xen-common/bin/xen-toolstack 2>/dev/null)
> +	if [ $? -ne 0 ]; then
> +		log_warning_msg "No usable Xen toolstack selected"
> +		exit 0
> +	fi
This is, or at least should be, a null change.

The error handling is a bit off, it should not care about the value.

Bastian

-- 
Without freedom of choice there is no creativity.
		-- Kirk, "The return of the Archons", stardate 3157.4

Your message dated Sat, 14 Apr 2012 18:20:00 +0200
with message-id <20120414162000.GA23971 at wavehammer.waldi.eu.org>
and subject line Re: [Pkg-xen-devel] Bug#661687: Bug#661687: xen-utils-common:
TOOLSTACK setting not honored
has caused the Debian Bug report #661687,
regarding xen-utils-common: TOOLSTACK setting not honored
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner at bugs.debian.org
immediately.)


-- 
661687: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=661687
Debian Bug Tracking System
Contact owner at bugs.debian.org with problems
-------------- next part --------------
An embedded message was scrubbed...
From: Ritesh Raj Sarraf <rrs at debian.org>
Subject: xen-utils-common: TOOLSTACK setting not honored
Date: Thu, 01 Mar 2012 00:04:09 +0530
Size: 4066
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20120414/cd9c4648/attachment.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: Bastian Blank <waldi at debian.org>
Subject: Re: [Pkg-xen-devel] Bug#661687: Bug#661687: xen-utils-common: TOOLSTACK
setting not honored
Date: Sat, 14 Apr 2012 18:20:00 +0200
Size: 2045
URL:
<http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20120414/cd9c4648/attachment-0001.mht>