Ian Campbell
2008-Jul-20 13:32 UTC
[Pkg-xen-devel] Bug#481105: [PATCH] adjust patch to pygrub and hvmloader
I just tripped over this issue with pygrub. The code is written such that saying bootloader="pygrub" should cause the correct path to be used, the attached patch simply fixes this path to be correct. I don't have an HVM capable test machine handy (so I can't actually confirm this works) but I think changing the default "kernel" for an HVM guest to point to the correct path the hvmloader makes sense and at least partially addresses the concern in the bug report. A more complete change could be made such that the string "hvmloader" will default to the correct path as with pygrub, but that seems like an upstream thing. Ian. -- Ian Campbell Your motives for doing whatever good deed you may have in mind will be misinterpreted by somebody. -------------- next part -------------- A non-text attachment was scrubbed... Name: 481105.patch Type: text/x-patch Size: 2501 bytes Desc: not available Url : http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20080720/40c15e12/attachment.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: This is a digitally signed message part Url : http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20080720/40c15e12/attachment.pgp
Bastian Blank
2008-Jul-20 15:51 UTC
[Pkg-xen-devel] Bug#481105: [PATCH] adjust patch to pygrub and hvmloader
On Sun, Jul 20, 2008 at 02:32:54PM +0100, Ian Campbell wrote:> I just tripped over this issue with pygrub. The code is written such > that saying bootloader="pygrub" should cause the correct path to be > used, the attached patch simply fixes this path to be correct.No, this is not the correct fix. The value should be rewritten in tools/python/xen/xm/create.py, but this seems to not work correctly. Bastian -- Our way is peace. -- Septimus, the Son Worshiper, "Bread and Circuses", stardate 4040.7.
Bastian Blank
2008-Jul-20 15:53 UTC
[Pkg-xen-devel] Bug#481105: Bug#481105: [PATCH] adjust patch to pygrub and hvmloader
On Sun, Jul 20, 2008 at 02:32:54PM +0100, Ian Campbell wrote:> I just tripped over this issue with pygrub. The code is written such > that saying bootloader="pygrub" should cause the correct path to be > used, the attached patch simply fixes this path to be correct.No, this is not the correct fix. The value should be rewritten in tools/python/xen/xm/create.py, but this seems to not work correctly. Bastian -- Our way is peace. -- Septimus, the Son Worshiper, "Bread and Circuses", stardate 4040.7.
Ian Campbell
2008-Jul-20 17:11 UTC
[Pkg-xen-devel] Bug#481105: Bug#481105: [PATCH] adjust patch to pygrub and hvmloader
On Sun, 2008-07-20 at 17:53 +0200, Bastian Blank wrote:> On Sun, Jul 20, 2008 at 02:32:54PM +0100, Ian Campbell wrote: > > I just tripped over this issue with pygrub. The code is written such > > that saying bootloader="pygrub" should cause the correct path to be > > used, the attached patch simply fixes this path to be correct. > > No, this is not the correct fix. The value should be rewritten in > tools/python/xen/xm/create.py, but this seems to not work correctly.You mean to change: if vals.bootloader: if vals.bootloader == "pygrub": vals.bootloader = osdep.pygrub_path instead of changing the definition of osdep.pygrub_path? Why is that preferred? It seems like the whole purpose of the osdep module is to abstract away differences between OSs (and distros...) Ian -- Ian Campbell Alter.net seems to have replaced one of its router with a zucchini. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: This is a digitally signed message part Url : http://lists.alioth.debian.org/pipermail/pkg-xen-devel/attachments/20080720/16f2d2e8/attachment.pgp
Marco Sinhoreli
2008-Jul-21 18:07 UTC
[Pkg-xen-devel] Bug#481105: Bug#481105: Bug#481105: [PATCH] adjust patch to pygrub and hvmloader
Hello Ian and waldi, In virtinst package, we are pointing the pygrub and hvmloader to /etc/xen-default/bin directory files. To us, this is sufficient to fix our package issue. I suggest to use alternatives to point these to /usr/bin and so, standardize with another distros. Well, I think this is the easy way to solve it. Cheers, On Sun, Jul 20, 2008 at 2:11 PM, Ian Campbell <ijc at hellion.org.uk> wrote:> On Sun, 2008-07-20 at 17:53 +0200, Bastian Blank wrote: >> On Sun, Jul 20, 2008 at 02:32:54PM +0100, Ian Campbell wrote: >> > I just tripped over this issue with pygrub. The code is written such >> > that saying bootloader="pygrub" should cause the correct path to be >> > used, the attached patch simply fixes this path to be correct. >> >> No, this is not the correct fix. The value should be rewritten in >> tools/python/xen/xm/create.py, but this seems to not work correctly. > > You mean to change: > if vals.bootloader: > if vals.bootloader == "pygrub": > vals.bootloader = osdep.pygrub_path > instead of changing the definition of osdep.pygrub_path? Why is that > preferred? It seems like the whole purpose of the osdep module is to > abstract away differences between OSs (and distros...) > > Ian > -- > Ian Campbell > > Alter.net seems to have replaced one of its router with a zucchini. > > _______________________________________________ > Pkg-xen-devel mailing list > Pkg-xen-devel at lists.alioth.debian.org > http://lists.alioth.debian.org/mailman/listinfo/pkg-xen-devel >-- Marco Sinhoreli Hello
Apparently Analagous Threads
- backport upstream pygrub fixes to allow booting squeeze default install?
- [PATCH 1/7] Fix pygrub path on Solaris
- Bug#481105: adjust patch to pygrub and hvmloader
- Bug#481105: xen-utils-3.2-1: Need to ajust path to pygrub and hvmloader
- Bug#481105: adjust patch to pygrub and hvmloader