pkg kde talk - Jul 2005 - Re: [Pkg-kde-commits] rev 1349 - trunk/packages/qt-x11-free/debian

> Author: chrsmrtn-guest
> New Revision: 1350
> Modified:Sat, 23 Jul 2005 00:48:15 +0200
>    trunk/packages/qt-x11-free/debian/control
> Log:
> Remove ''c102'' from libqt3-dev and
libqt3-mt-dev''s depends (on libqt3...).
  Good one, thanks a lot!
> New Revision: 1351
> Removed:
>    people/chrsmrtn/qt-x11-free/debian/patches/30_gcc4_build.dpatch
> Modified:
>    people/chrsmrtn/qt-x11-free/debian/patches/00list
> Log:
> Remove unnecessary gcc4 patch.
> -30_gcc4_build.dpatch
>  31_gcc4_buildkey.dpatch
  And hum, 31_gcc4_buildkey must really really go into trunk (otherwise
  the buildkey would check after a new upload, if the compiler changed
  in between). Will commit now.
> New Revision: 1349
  
  I have a couple comments about this one.
> Modified:
>    trunk/packages/qt-x11-free/debian/control
> Log:
> Add new libxi-dev to the build-depends, dev package depends.
  Can we get a changelog entry for this? But more importantly:
> Since this is needed for other KDE packages,
  Is this confirmed? If so, shouldn''t these packages be depending
  themselves on libxi-dev, instead of relying on qt3-dev doing so?
> having this pulled in is handy.
> In Qt, required for (at the very least) tablet support.
  I''d prefer to add the build-dependency only when needed, i.e. in -5
  when tablet support is added.

  Cheers,

-- 
Adeodato Sim?
    EM: asp16 [ykwim] alu.ua.es | PK: DA6AE621
 
ech`echo xiun|tr nu oc|sed ''sx\([sx]\)\([xoi]\)xo un\2\1 is
xg''`ol

Quoting Adeodato Sim? <asp16@alu.ua.es>:
> > New Revision: 1349
>   
>   I have a couple comments about this one.
> 
> > Modified:
> >    trunk/packages/qt-x11-free/debian/control
> > Log:
> > Add new libxi-dev to the build-depends, dev package depends.
> 
>   Can we get a changelog entry for this? But more importantly:
>
> > Since this is needed for other KDE packages,
> 
>   Is this confirmed? If so, shouldn''t these packages be depending
>   themselves on libxi-dev, instead of relying on qt3-dev doing so?
kdelibs, kdewebdev, IIRC, but I didn''t do a thorough check. As for the
general issue, thus far the packages have simply been using qt and kdelibs
dev packages to pull in basic build deps. It''s a convenient but lazy
practice, of course, and if you feel this ought to change then we can work
on cleaning the situation up.
 
> > having this pulled in is handy.
> > In Qt, required for (at the very least) tablet support.
> 
>   I''d prefer to add the build-dependency only when needed, i.e. in
-5
>   when tablet support is added.
Argh! Not only did I completely forget about the 3.4.2 release date issue,
but I somehow thought that the package in trunk had enabled tablet support
(as I had in my more experimental packaging).

Perhaps kdelibs could get the dependency on libxi-dev for the time being
instead (and add it to the kdelibs4-dev''s deps as well, perhaps. As for
kdewebdev, or other packages that need it... ?).

Cheers,
Chris

* Christopher Martin [Sun, 24 Jul 2005 00:05:49 -0400]:
> Quoting Adeodato Sim? <asp16@alu.ua.es>:
> >   Is this confirmed? If so, shouldn''t these packages be
depending
> >   themselves on libxi-dev, instead of relying on qt3-dev doing so?
> kdelibs, kdewebdev, IIRC, but I didn''t do a thorough check. As for
the
> general issue, thus far the packages have simply been using qt and kdelibs
> dev packages to pull in basic build deps. It''s a convenient but
lazy
> practice, of course, and if you feel this ought to change then we can work
> on cleaning the situation up.
> >   I''d prefer to add the build-dependency only when needed,
i.e. in -5
> >   when tablet support is added.
> Argh! Not only did I completely forget about the 3.4.2 release date issue,
> but I somehow thought that the package in trunk had enabled tablet support
> (as I had in my more experimental packaging).
> Perhaps kdelibs could get the dependency on libxi-dev for the time being
> instead (and add it to the kdelibs4-dev''s deps as well, perhaps.
As for
> kdewebdev, or other packages that need it... ?).
  Nah, I''m fine with putting it in the Depends line of libqt3-*-dev as
  long as it''s noted in the changelog.

  So, I''ll remove it from build-depends, and add a changelog entry in
  the appropriate place. What tag do you prefer to mark the change as
  yours? I''ve used "[cm]", feel free to change it.

  And with this (will wait for an answer of the "[cm]" bit above), I
  think we can declare qt-x11-free 3.3.4-4 ready to go. Objections?

-- 
Adeodato Sim?
    EM: asp16 [ykwim] alu.ua.es | PK: DA6AE621
    Listening to: Astrud - Es incre?ble (Espeluznante)
 
When the only tool you have is a hammer, every problem starts to look
like a nail.

On July 24, 2005 10:36, Adeodato Sim? wrote:
>   I''m fine with putting it in the Depends line of libqt3-*-dev as
>   long as it''s noted in the changelog.
>
>   So, I''ll remove it from build-depends, and add a changelog entry
in
>   the appropriate place. What tag do you prefer to mark the change as
>   yours? I''ve used "[cm]", feel free to change it.
Sounds good. [cm] is fine as well.
>   And with this (will wait for an answer of the "[cm]" bit
above), I
>   think we can declare qt-x11-free 3.3.4-4 ready to go. Objections?
None here.

Cheers,
Chris