Darryl L. Pierce
2009-Aug-18 14:34 UTC
[Ovirt-devel] [PATCH node] Fixes when the user aborts DNS entry then retries it.
Previously the code did not empty the $DNS variable when the user said
the configuration was incorrect. Now, when they say it's incorrect, the
variable is blanked.
Resolves: rhbz#518021
Signed-off-by: Darryl L. Pierce <dpierce at redhat.com>
---
scripts/ovirt-config-networking | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/ovirt-config-networking b/scripts/ovirt-config-networking
index e114538..7d4e363 100755
--- a/scripts/ovirt-config-networking
+++ b/scripts/ovirt-config-networking
@@ -343,7 +343,7 @@ function configure_dns
ask_yes_or_no "Is this correct ([Y]es/[N]o/[A]bort)?"
true true
case $? in
0) break ;;
- 1) ;;
+ 1) DNS="";;
2) return ;;
esac
done
--
1.6.2.5
Joey Boggs
2009-Aug-20 13:53 UTC
[Ovirt-devel] [PATCH node] Fixes when the user aborts DNS entry then retries it.
Darryl L. Pierce wrote:> Previously the code did not empty the $DNS variable when the user said > the configuration was incorrect. Now, when they say it's incorrect, the > variable is blanked. > > Resolves: rhbz#518021 > > Signed-off-by: Darryl L. Pierce <dpierce at redhat.com> > --- > scripts/ovirt-config-networking | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/scripts/ovirt-config-networking b/scripts/ovirt-config-networking > index e114538..7d4e363 100755 > --- a/scripts/ovirt-config-networking > +++ b/scripts/ovirt-config-networking > @@ -343,7 +343,7 @@ function configure_dns > ask_yes_or_no "Is this correct ([Y]es/[N]o/[A]bort)?" true true > case $? in > 0) break ;; > - 1) ;; > + 1) DNS="";; > 2) return ;; > esac > done >ACK
Apparently Analagous Threads
- [PATCH node] Make all yes/no prompts consistent. rhbz#508778
- [PATCH node] validify ipv4/ipv6 static/dhcp choice else loop
- [PATCH node] Rerunning network config resets all network config. bz#507393
- [PATCH node] REPOST Joey's and Darryl's ovirt-config-* patches
- RESEND: [PATCH node 1/3] enables ability for a common shared root