On 2019-04-14 9:35 a.m., zol wrote:> When trying to play vorbis or opus files that have large cover sizes > >1MB on android 8.0 built in player, they fail to play. Removing the > cover allows them to play.I didn't investigate very closely (and my android 8 device has always ignored opus files!) But I'd guess it's either a bug with re-assembling the larger metadata header or the buffer the player is passing to the sniffer for file identification is too small. There is a 16 MB limit for metadata in the Android ogg/opus parser. Your cover images aren't that large are they? https://android.googlesource.com/platform/frameworks/av/+/a1a005fc01118685c92e723c8dcf7afeffc9d59c/media/extractors/ogg/OggExtractor.cpp#707 -r
Ralph Giles wrote:> There is a 16 MB limit for metadata in the Android ogg/opus parser. Your > cover images aren't that large are they? > > https://android.googlesource.com/platform/frameworks/av/+/a1a005fc01118685c92e723c8dcf7afeffc9d59c/media/extractors/ogg/OggExtractor.cpp#707Technically, according to RFC 7845 Section 5.2, they're only allowed to reject files if the comment header is larger than 120 MB. They are allowed to ignore any comments beyond the first 60 kB of that header, however. So if you wanted you could file a bug against Android about it.
>>> "Timothy B. Terriberry" <tterribe at xiph.org> schrieb am 15.04.2019 um 22:32 inNachricht <21fbcf68-6b5a-b93b-7cd5-568566bc9989 at xiph.org>:> Ralph Giles wrote: >> There is a 16 MB limit for metadata in the Android ogg/opus parser. Your >> cover images aren't that large are they? >> >> > https://android.googlesource.com/platform/frameworks/av/+/a1a005fc01118685c92 > e723c8dcf7afeffc9d59c/media/extractors/ogg/OggExtractor.cpp#707 > > Technically, according to RFC 7845 Section 5.2, they're only allowed to > reject files if the comment header is larger than 120 MB. They are > allowed to ignore any comments beyond the first 60 kB of that header, > however. > > So if you wanted you could file a bug against Android about it.The other thing is whether it makes sense to add such large images: Usually I try to reduce my cover arts to less tan 40kB. That works in most cases, but some requite a litle less than 150kB. OK, that's for mobile phone; if you have a UHD tablet, your requirements may be different ;-) Despite of that I have my cover arts outside the actual files, usually...> _______________________________________________ > opus mailing list > opus at xiph.org > http://lists.xiph.org/mailman/listinfo/opus
Reasonably Related Threads
- large cover size bug with android?
- large cover size bug with android?
- Fwd: [codec] RFC 7845 on Ogg Encapsulation for the Opus Audio Codec
- [RFC PATCHv1] cover: celt_pitch_xcorr: Introduce ARM neon intrinsics
- [RFC PATCHv1] cover: celt_pitch_xcorr: Introduce ARM neon intrinsics