opus - Jul 2016 - [PATCH] SILK: use silk_memmove for potentially overlapping areas

Fixes CID 1227580
---
 silk/process_NLSFs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/silk/process_NLSFs.c b/silk/process_NLSFs.c
index c27cf03..d9123ef 100644
--- a/silk/process_NLSFs.c
+++ b/silk/process_NLSFs.c
@@ -100,6 +100,6 @@ void silk_process_NLSFs(
 
     } else {
         /* Copy LPC coefficients for first half from second half */
-        silk_memcpy( PredCoef_Q12[ 0 ], PredCoef_Q12[ 1 ],
psEncC->predictLPCOrder * sizeof( opus_int16 ) );
+        silk_memmove( PredCoef_Q12[ 0 ], PredCoef_Q12[ 1 ],
psEncC->predictLPCOrder * sizeof( opus_int16 ) );
     }
 }
-- 
2.8.1

Tristan Matthews wrote:
> Fixes CID 1227580
I don't believe this is an actual error. If it's truly possible for 
these areas to overlap (I don't think it is), then something much more 
serious than using memmove instead of memcpy needs to be done about it.