For definition of off_t type, stream.c needs including sys/types.h. I hit this requirement at least once when compiling against Mac OSX 10.4 SDK. Trivial patch inlined below. --- opusfile/src/stream.c~ +++ opusfile/src/stream.c @@ -14,6 +14,7 @@ last mod: $Id: vorbisfile.c 17573 2010-10-27 14:53:59Z xiphmont $ ********************************************************************/ +#include <sys/types.h> #include "internal.h" #include <stdio.h> #include <stdlib.h> -- O.S.
Uhm I would probably suggest adding a check for this as I'm not sure if all operating systems have or need sys/types.h. Diego Elio Petten? ? Flameeyes flameeyes at flameeyes.eu ? http://blog.flameeyes.eu/ On Wed, May 1, 2013 at 12:46 PM, Ozkan Sezer <sezeroz at gmail.com> wrote:> For definition of off_t type, stream.c needs including sys/types.h. I > hit this requirement at least once when compiling against Mac OSX 10.4 > SDK. Trivial patch inlined below. > > --- opusfile/src/stream.c~ > +++ opusfile/src/stream.c > @@ -14,6 +14,7 @@ > last mod: $Id: vorbisfile.c 17573 2010-10-27 14:53:59Z xiphmont $ > > ********************************************************************/ > +#include <sys/types.h> > #include "internal.h" > #include <stdio.h> > #include <stdlib.h> > > -- > O.S. > _______________________________________________ > opus mailing list > opus at xiph.org > http://lists.xiph.org/mailman/listinfo/opus
On Wed, May 1, 2013 at 2:48 PM, Diego Elio Petten? <flameeyes at flameeyes.eu> wrote:> Uhm I would probably suggest adding a check for this as I'm not sure > if all operating systems have or need sys/types.h. >That would require opusfile to generate and use a config.h which, unlike opus, it doesn't do for the time being. (autogen.sh doesn't work for me cleanly, so I can't do that myself.) FWIW, opusfile already includes sys/types.h in http.c without any configury check.> Diego Elio Petten? ? Flameeyes > flameeyes at flameeyes.eu ? http://blog.flameeyes.eu/ > > > On Wed, May 1, 2013 at 12:46 PM, Ozkan Sezer <sezeroz at gmail.com> wrote: >> For definition of off_t type, stream.c needs including sys/types.h. I >> hit this requirement at least once when compiling against Mac OSX 10.4 >> SDK. Trivial patch inlined below. >> >> --- opusfile/src/stream.c~ >> +++ opusfile/src/stream.c >> @@ -14,6 +14,7 @@ >> last mod: $Id: vorbisfile.c 17573 2010-10-27 14:53:59Z xiphmont $ >> >> ********************************************************************/ >> +#include <sys/types.h> >> #include "internal.h" >> #include <stdio.h> >> #include <stdlib.h> >> >> -- >> O.S. >> _______________________________________________ >> opus mailing list >> opus at xiph.org >> http://lists.xiph.org/mailman/listinfo/opus-- O.S.