openssh unix dev - Jul 2019 - [PATCH] regress: Fix possible memleaks

Hello,

Could attached patch be reviewed. This patch provides a fix for bug:
https://bugzilla.mindrot.org/show_bug.cgi?id=3037

Thanks,
Jitendra

Hi.

On Mon, 29 Jul 2019 at 13:21, Sharma, Jitendra
<jitendra.sharma at intel.com> wrote:
> Could attached patch be reviewed. This patch provides a fix for bug:
> https://bugzilla.mindrot.org/show_bug.cgi?id=3037
We appreciate contributions, however this one is (a) a mem leak (b) in
a test harness that (c) exits immediately, and (d) the bug report was
from 4 days ago so it's not exactly an emergency.   Also, (e) the bug
report was closed by you.

Please understand that this is no-one's full time job and sending
reminders after a couple of days is counterproductive.  If you want
stuff looked at please file a bug and leave it open. We do periodic
sweeps and trivial things will typically be picked up within a week or
two and the bug closed when the fix is committed.   (Non-trivial
things are subject availability of sufficient time and/or interest,
including that we'll have to support those things long term).

-- 
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.

Hi Daren,

Thanks for replying.
I filed the bug and after submitting the patch, I put it in resolved fix state,
assuming that after resolved fix state, it will move to some test stage. So,
please accept my apologies for not understanding the complete workflow. I will
follow the steps for filing bugs as guided by you below.

I also understand that sending reminders in just two days is not good, and would
accept that after submitting patches I will wait for at least a week or more.
But what leads to my uncertainty is that recently I submitted some
patches(Around 20 days ago) to Openssh-unix-dev mailing list:
1) [PATCH] Remove perm_ok argument from sshkey_load_private_type 
2) [PATCH 2/2] Remove sshkey_load_private()

And for these I didn?t get any feedback. So, I was in a guessing state as
whether I am sending patches correctly or following proper protocols for sending
patches. Probably it would be great if you could guide, as a Openssh contributor
after sending patches for review, what should be patch submitter's next
course of action.

Thanks,
Jitendra

-----Original Message-----
From: Darren Tucker [mailto:dtucker at dtucker.net] 
Sent: Monday, July 29, 2019 12:03 PM
To: Sharma, Jitendra <jitendra.sharma at intel.com>
Cc: openssh-unix-dev at mindrot.org
Subject: Re: [PATCH] regress: Fix possible memleaks

Hi.

On Mon, 29 Jul 2019 at 13:21, Sharma, Jitendra <jitendra.sharma at
intel.com> wrote:
> Could attached patch be reviewed. This patch provides a fix for bug:
> https://bugzilla.mindrot.org/show_bug.cgi?id=3037
We appreciate contributions, however this one is (a) a mem leak (b) in a test
harness that (c) exits immediately, and (d) the bug report was
from 4 days ago so it's not exactly an emergency.   Also, (e) the bug
report was closed by you.

Please understand that this is no-one's full time job and sending reminders
after a couple of days is counterproductive.  If you want stuff looked at please
file a bug and leave it open. We do periodic sweeps and trivial things will
typically be picked up within a week or
two and the bug closed when the fix is committed.   (Non-trivial
things are subject availability of sufficient time and/or interest, including
that we'll have to support those things long term).

--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience usually
comes from bad judgement.