openssh unix dev - Apr 2017 - Any interest in a patch for setting the syslog facility for the ssh client?

To revive this thread - I filed a bug in bugzilla.mindrot.org ( Bug 2705 -
https://bugzilla.mindrot.org/show_bug.cgi?id=2705 ).

I have a patch attached to the email that implements this as well. I wasn't
able to find a list of coding standards or contribution guidelines for
OpenSSH, so please correct me if I'm wrong. I'd also like to thank
Jakuje
for helping me out with some info on the whitespace standards a few months
ago when I posted this on GitHub.

Cheers,

Ethan

On Mon, Jan 9, 2017 at 5:15 PM, Darren Tucker <dtucker at zip.com.au>
wrote:
> On Tue, Jan 10, 2017 at 11:34 AM, Ethan Rahn <ethan.rahn at
gmail.com> wrote:
> > I recently made a change to the openssh ssh client code to allow
> > configuring the client syslog facility to use. I made the change in
> > openssh-6.6p1. If there is interest I can port the change to the
openssh
> > portable github.
>
> Sounds reasonable.
>
> --
> Darren Tucker (dtucker at zip.com.au)
> GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
>     Good judgement comes with experience. Unfortunately, the experience
> usually comes from bad judgement.
>

On Fri, Apr 7, 2017 at 4:45 PM, Ethan Rahn <ethan.rahn at gmail.com>
wrote:
> To revive this thread - I filed a bug in bugzilla.mindrot.org ( Bug 2705
> - https://bugzilla.mindrot.org/show_bug.cgi?id=2705 ).
>
> I have a patch attached to the email that implements this as well. I
> wasn't able to find a list of coding standards or contribution
guidelines
> for OpenSSH,
>
In general, the OpenBSD style guide.  From the README:

 Code contribution are welcomed, but please follow the OpenBSD
style guidelines[6].
[...]
[6] http://man.openbsd.org/style.9

--
Darren Tucker (dtucker at zip.com.au)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.

Darren,

Thanks, evidently I need to practice my reading skills. I did some practice
on the style guide, and I believe that I have the patch fixed up per the
style guidelines. I've attached the new patch to this email for review.

Cheers,

Ethan

On Fri, Apr 7, 2017 at 5:02 AM, Darren Tucker <dtucker at zip.com.au>
wrote:
> On Fri, Apr 7, 2017 at 4:45 PM, Ethan Rahn <ethan.rahn at gmail.com>
wrote:
>
>> To revive this thread - I filed a bug in bugzilla.mindrot.org ( Bug
2705
>> - https://bugzilla.mindrot.org/show_bug.cgi?id=2705 ).
>>
>> I have a patch attached to the email that implements this as well. I
>> wasn't able to find a list of coding standards or contribution
guidelines
>> for OpenSSH,
>>
>
> In general, the OpenBSD style guide.  From the README:
>
>  Code contribution are welcomed, but please follow the OpenBSD
> style guidelines[6].
> [...]
> [6] http://man.openbsd.org/style.9
>
> --
> Darren Tucker (dtucker at zip.com.au)
> GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
>     Good judgement comes with experience. Unfortunately, the experience
> usually comes from bad judgement.
>