On Wed, 17 Feb 2016, Hisashi T Fujinaka wrote:> > This one is failing a test assetion - there should be some more useful > > output available from the test itself. > > I think it's this: > > test_hostkeys: > regress/unittests/hostkeys/test_iterate.c:163 test #1 "hostkeys_iterate all > with key parse" > ASSERT_INT_EQ(sshkey_load_public( test_data_file(expected[i].key_file), > &expected[i].l.key, NULL), 0) failed: > sshkey_load_public( test_data_file(expected[i].key_file), &expected[i].l.key, > NULL) = -24I need to make these error messages more user-friendly :( -24 is SSH_ERR_SYSTEM_ERROR, so it's likely failing to find/load the key for some reason. I'll make a patch to improve the error message, but in the meantime you could probably figure out the exact failure using ktrace/ktruss/strace and/or digging errno out of the core file. -d
On Thu, 18 Feb 2016, Damien Miller wrote:> On Wed, 17 Feb 2016, Hisashi T Fujinaka wrote: > >>> This one is failing a test assetion - there should be some more useful >>> output available from the test itself. >> >> I think it's this: >> >> test_hostkeys: >> regress/unittests/hostkeys/test_iterate.c:163 test #1 "hostkeys_iterate all >> with key parse" >> ASSERT_INT_EQ(sshkey_load_public( test_data_file(expected[i].key_file), >> &expected[i].l.key, NULL), 0) failed: >> sshkey_load_public( test_data_file(expected[i].key_file), &expected[i].l.key, >> NULL) = -24 > > I need to make these error messages more user-friendly :( > > -24 is SSH_ERR_SYSTEM_ERROR, so it's likely failing to find/load the > key for some reason. I'll make a patch to improve the error message, > but in the meantime you could probably figure out the exact failure > using ktrace/ktruss/strace and/or digging errno out of the core file.Do I have to fish the actual invocation of test_hostkeys from somewhere too? -- Hisashi T Fujinaka - htodd at twofifty.com BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee
On Wed, 17 Feb 2016, Hisashi T Fujinaka wrote:> > I need to make these error messages more user-friendly :( > > > > -24 is SSH_ERR_SYSTEM_ERROR, so it's likely failing to find/load the > > key for some reason. I'll make a patch to improve the error message, > > but in the meantime you could probably figure out the exact failure > > using ktrace/ktruss/strace and/or digging errno out of the core file. > > Do I have to fish the actual invocation of test_hostkeys from somewhere > too?Probably not, if you ktrace or similar you need only look for the last failing syscall (probably open) before the output of the error message. -d