On Wed, 17 Feb 2016, Hisashi T Fujinaka wrote:> And in another "oh duh" moment, I think this dumped core on two different > machines and I sent you the bt from the wrong machine. Here's the one > from NetBSD-7. > > #0 0x00007f7ff630e55a in _lwp_kill () from /usr/lib/libc.so.12 > (gdb) bt > #0 0x00007f7ff630e55a in _lwp_kill () from /usr/lib/libc.so.12 > #1 0x00007f7ff630e1e5 in abort () at /usr/src/lib/libc/stdlib/abort.c:74 > #2 0x0000000000429992 in test_die () at > regress/unittests/test_helper/test_helper.c:290 > #3 0x0000000000406b0a in assert_int (file=file at entry=0x42a188 > "regress/unittests/hostkeys/test_iterate.c", line=line at entry=163, > a1=a1 at entry=0x42a1e0 "sshkey_load_public( > test_data_file(expected[i].key_file), &expected[i].l.key, NULL)", > a2=a2 at entry=0x42d2cf "0", aa1=-24, aa2=aa2 at entry=0,This one is failing a test assetion - there should be some more useful output available from the test itself. -d
On Thu, 18 Feb 2016, Damien Miller wrote:> On Wed, 17 Feb 2016, Hisashi T Fujinaka wrote: > >> And in another "oh duh" moment, I think this dumped core on two different >> machines and I sent you the bt from the wrong machine. Here's the one >> from NetBSD-7. >> >> #0 0x00007f7ff630e55a in _lwp_kill () from /usr/lib/libc.so.12 >> (gdb) bt >> #0 0x00007f7ff630e55a in _lwp_kill () from /usr/lib/libc.so.12 >> #1 0x00007f7ff630e1e5 in abort () at /usr/src/lib/libc/stdlib/abort.c:74 >> #2 0x0000000000429992 in test_die () at >> regress/unittests/test_helper/test_helper.c:290 >> #3 0x0000000000406b0a in assert_int (file=file at entry=0x42a188 >> "regress/unittests/hostkeys/test_iterate.c", line=line at entry=163, >> a1=a1 at entry=0x42a1e0 "sshkey_load_public( >> test_data_file(expected[i].key_file), &expected[i].l.key, NULL)", >> a2=a2 at entry=0x42d2cf "0", aa1=-24, aa2=aa2 at entry=0, > > This one is failing a test assetion - there should be some more useful > output available from the test itself.I think it's this: test_hostkeys: regress/unittests/hostkeys/test_iterate.c:163 test #1 "hostkeys_iterate all with key parse" ASSERT_INT_EQ(sshkey_load_public( test_data_file(expected[i].key_file), &expected[i].l.key, NULL), 0) failed: sshkey_load_public( test_data_file(expected[i].key_file), &expected[i].l.key, NULL) = -24 0 = 0 [1] Abort trap (core dumped) ${V} /home/htodd... *** Error code 134 -- Hisashi T Fujinaka - htodd at twofifty.com BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee
On Wed, 17 Feb 2016, Hisashi T Fujinaka wrote:> > This one is failing a test assetion - there should be some more useful > > output available from the test itself. > > I think it's this: > > test_hostkeys: > regress/unittests/hostkeys/test_iterate.c:163 test #1 "hostkeys_iterate all > with key parse" > ASSERT_INT_EQ(sshkey_load_public( test_data_file(expected[i].key_file), > &expected[i].l.key, NULL), 0) failed: > sshkey_load_public( test_data_file(expected[i].key_file), &expected[i].l.key, > NULL) = -24I need to make these error messages more user-friendly :( -24 is SSH_ERR_SYSTEM_ERROR, so it's likely failing to find/load the key for some reason. I'll make a patch to improve the error message, but in the meantime you could probably figure out the exact failure using ktrace/ktruss/strace and/or digging errno out of the core file. -d