Hello, running Coccinelle (http://coccinelle.lip6.fr/) on the DragonFly source tree with a patch to find issues of this kind turned up this one. Please see the attached diff (against OpenBSD). Regards, Sascha
On 15 June 2012 14:06, Sascha Wildner <saw at online.de> wrote:> Hello, > > running Coccinelle (http://coccinelle.lip6.fr/) on the DragonFly source tree > with a patch to find issues of this kind turned up this one. Please see the > attached diff (against OpenBSD).it got stripped. can you resend as a url? -- Eitan Adler
On 15/06/12 23:06, Sascha Wildner wrote:> Hello, > > running Coccinelle (http://coccinelle.lip6.fr/) on the DragonFly > source tree with a patch to find issues of this kind turned up this > one. Please see the attached diff (against OpenBSD). > > Regards, > SaschaDiff was stripped by the list. Resend as text/plain or provide a link.
On Fri, 15 Jun 2012 23:20:42 +0200, Peter Stuge <peter at stuge.se> wrote:> Sascha Wildner wrote: >> Please see the attached diff (against OpenBSD). > > No attachment. Possibly stripped by the list if not text/plain.Sorry, patch is here: http://87.78.98.243/stuff/jpake_sizeof.diff
On 15/06/12 23:31, Sascha Wildner wrote:> Sorry, patch is here: > > http://87.78.98.243/stuff/jpake_sizeof.diffWell found. That should indeed be applied. I think you should send it up to openssh at openssh.com <mailto:openssh at openssh.com>. The portable version will pick it the changes from there. Regards Below is the content of the referenced patch:> Index: usr.bin/ssh/jpake.c > ==================================================================> RCS file: /home/obcvs/src/usr.bin/ssh/jpake.c,v > retrieving revision 1.6 > diff -u -r1.6 jpake.c > --- usr.bin/ssh/jpake.c 20 Sep 2010 04:54:07 -0000 1.6 > +++ usr.bin/ssh/jpake.c 15 Jun 2012 20:13:22 -0000 > @@ -131,7 +131,7 @@ > #undef JPAKE_BN_CLEAR_FREE > #undef JPAKE_BUF_CLEAR_FREE > > - bzero(pctx, sizeof(pctx)); > + bzero(pctx, sizeof(*pctx)); > xfree(pctx); > } >