openssh unix dev - May 2007 - [PATCH] Adds support for SSH_FXP_LINK request to sftp-server and sftp client

Dear list,

Attached is a patch that adds support for the SSH_FXP_LINK request, as
described in draft-ietf-secsh-filexfer-07 onwards, to the sftp server
and client.  It is for and has been tested on the current portable
snapshot but also applies to openbsd CVS.

Thanks,
-- 
Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openssh-sftp-hardlink-pcvs-v2.patch
Type: text/x-diff
Size: 7108 bytes
Desc: not available
Url :
http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20070507/18e7efc0/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url :
http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20070507/18e7efc0/attachment-0001.bin

Dear list,

Attached is a patch that adds support for the SSH_FXP_LINK request, as
described in draft-ietf-secsh-filexfer-07 onwards, to the sftp server
and client.  It is for and has been tested on the current portable
snapshot but also applies to openbsd CVS.

Thanks,
-- 
Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openssh-sftp-hardlink-pcvs-v2.patch
Type: text/x-diff
Size: 7108 bytes
Desc: not available
Url :
http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20070507/2cef0666/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url :
http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20070507/2cef0666/attachment-0001.bin

Hi,
> Attached is a patch that adds support for the SSH_FXP_LINK request, as
> described in draft-ietf-secsh-filexfer-07 onwards, to the sftp server
> and client.
The "standard" for OpenSSH is draft-ietf-secsh-filexfer-03

$ grep FILEXFER_VERSION sftp.h
#define SSH2_FILEXFER_VERSION           3

I have tried the patch and it works.
But only if the client/server has the same patch installed.

There is a check inside the patch (sftp-client.c):

+ if (conn->version < 3) {
+     error("This server does not support the link operation");
+     return(SSH2_FX_OP_UNSUPPORTED);
+ }

A non patched server has version "3" (see sftp.h) but
it does not support the new link operation...

- Solutions:
1- Upgrade define SSH2_FILEXFER_VERSION to 4 ???
   (and also update the check)
2- Any other suggestion ???

- A question:
Does the patch will be included in the next stable release of OpenSSH?


Bye,

--
Daniele Calore ( orkaan at orkaan.org )