openssh unix dev - May 2003 - Resolver changes broke AIX & HPUX

Hi All.
	Haven't looked at this yet but it looks like the resolver changes broke
AIX and HP-UX.

		-Daz.

AIX 4.3.3.11:
gcc -g -O2 -Wall -Wpointer-arith -Wno-uninitialized -I. -I..
-I../../openbsd-compat -I../../openbsd-compat/.. -I/usr/local/ssl/include 
-I/usr/local/include -DHAVE_CONFIG_H -c
../../openbsd-compat/getrrsetbyname.c
../../openbsd-compat/getrrsetbyname.c:133: warning: static declaration for
`_getshort? follows non-static
../../openbsd-compat/getrrsetbyname.c:143: conflicting types for
`_getlong?
/usr/include/arpa/onameser_compat.h:322: previous declaration of
`_getlong?
../../openbsd-compat/getrrsetbyname.c: In function `getrrsetbyname?:
../../openbsd-compat/getrrsetbyname.c:238: structure has no member named
`ad?

HP-UX 11.00:
ccache gcc -g -O2 -fomit-frame-pointer -pipe -Wall -Wpointer-arith
-Wno-uninitialized -I. -I.. -I. -I./.. -I/usr/local/ssl/include 
-D_HPUX_SOURCE -D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED=1 -DHAVE_CONFIG_H
-c getrrsetbyname.c
getrrsetbyname.c:133: warning: static declaration for `_getshort' follows
non-static
getrrsetbyname.c:143: warning: static declaration for `_getlong' follows
non-static
getrrsetbyname.c: In function `getrrsetbyname':
getrrsetbyname.c:183: warning: implicit declaration of function `res_init'
getrrsetbyname.c:199: warning: implicit declaration of function
`res_query'
getrrsetbyname.c:238: structure has no member named `ad'
getrrsetbyname.c: In function `parse_dns_qsection':
getrrsetbyname.c:426: warning: implicit declaration of function
`dn_expand'
make[1]: *** [getrrsetbyname.o] Error 1
make[1]: Leaving directory
`/home/builder/c240/openssh-tinderbox/openbsd-compat'
make: *** [openbsd-compat/libopenbsd-compat.a] Error 2

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.

Darren Tucker wrote:
> gcc [opts] openbsd-compat/getrrsetbyname.c
[snip]
> ../../openbsd-compat/getrrsetbyname.c: In function `getrrsetbyname?:
> ../../openbsd-compat/getrrsetbyname.c:238: structure has no member named
> `ad?
This looks like there should be a "#ifdef RES_USE_DNSSEC" around that
block.  With the attached patch, the compile proceeds further I now get
the following error (on HP-UX haven't tried AIX yet).

		-Daz.

gcc -g -O2 -Wall -Wpointer-arith -Wno-uninitialized -I. -I..
-I/usr/local/ssl/include  -D_HPUX_SOURCE -D_XOPEN_SOURCE
-D_XOPEN_SOURCE_EXTENDED=1 -DSSHDIR=\"/usr/local/etc\"
-D_PATH_SSH_PROGRAM=\"/usr/local/bin/ssh\"
-D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/libexec/ssh-askpass\"
-D_PATH_SFTP_SERVER=\"/usr/local/libexec/sftp-server\"
-D_PATH_SSH_KEY_SIGN=\"/usr/local/libexec/ssh-keysign\"
-D_PATH_SSH_PIDDIR=\"/var/run\"
-D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\"
-DSSH_RAND_HELPER=\"/usr/local/libexec/ssh-rand-helper\"
-DHAVE_CONFIG_H
-c ../session.c
../session.c: In function `session_break_req':
../session.c:1758: `TIOCSBRK' undeclared (first use in this function)
../session.c:1758: (Each undeclared identifier is reported only once
../session.c:1758: for each function it appears in.)
../session.c:1761: `TIOCCBRK' undeclared (first use in this function)
make: *** [session.o] Error 1

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
-------------- next part --------------
Index: openbsd-compat/getrrsetbyname.c
==================================================================RCS file:
/usr/local/src/security/openssh/cvs/openssh_cvs/openbsd-compat/getrrsetbyname.c,v
retrieving revision 1.1
diff -u -r1.1 getrrsetbyname.c
--- openbsd-compat/getrrsetbyname.c	15 May 2003 02:27:08 -0000	1.1
+++ openbsd-compat/getrrsetbyname.c	15 May 2003 10:44:30 -0000
@@ -234,9 +234,11 @@
 	rrset->rri_ttl = response->answer->ttl;
 	rrset->rri_nrdatas = response->header.ancount;
 
+#ifdef RES_USE_DNSSEC
 	/* check for authenticated data */
 	if (response->header.ad == 1)
 		rrset->rri_flags |= RRSET_VALIDATED;
+#endif
 
 	/* copy name from answer section */
 	length = strlen(response->answer->name);

Darren Tucker wrote:
> Hi All.
> 	Haven't looked at this yet but it looks like the resolver changes
broke
> AIX and HP-UX.
I'll have made it conditional on --with-dns.

We may need header tests for _getshort & _getlong in the 
--with-dns block in configure.ac. However, if the underlying 
resolver is insufficient, don't bother.

-d