openssh unix dev - May 2003 - [Bug 463] PrintLastLog doesn't work in privsep mode

http://bugzilla.mindrot.org/show_bug.cgi?id=463





------- Additional Comments From dtucker at zip.com.au  2003-05-10 12:59 -------
I've had a look at the OpenBSD source and I don't think OpenBSD *needs*
a
"Buffer loginmsg" right now.  PrintLastLog can be easily fixed by
updating
s->last_login_time before the privsep split.

So, is there another reason OpenBSD needs (or wants) a "Buffer
loginmsg"?  Or
should it be -portable only?  Have I overlooked something?  And what's the 
feeling on the montitor call in attachment #235?



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=463





------- Additional Comments From djm at mindrot.org  2003-05-10 16:40 -------
Yes, the privsep split occurs post-auth, not once per session. Remember that a
SSH2 connection may have multiple sessions (the ssh.com windows client allows
this). 

If you collect the last login time at the time of the privsep split, then that
would be displayed for all sessions.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=463





------- Additional Comments From dtucker at zip.com.au  2003-05-10 17:49 -------
OK, so if I understand correctly, the only guaranteed way to get the last login 
time is via a monitor call, so I hopefully won't get accused of bloat for 
proposing one...



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=463





------- Additional Comments From djm at mindrot.org  2003-05-10 18:59 -------
Certainly not!



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=463





------- Additional Comments From dtucker at zip.com.au  2003-05-10 19:34 -------
Created an attachment (id=287)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=287&action=view)
Generate loginmsg as part of login recording (against OpenBSD -current)

OK, here's the proposed patch against OpenBSD.	The call to
store_lastlog_message is where it is in record_login because under AIX the
login message is generated as a side effect of loginsuccess().	The location
under OpenBSD is not critical since it's a read-only operation.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=463





------- Additional Comments From dtucker at zip.com.au  2003-05-10 22:22 -------
Hmm, this will probably give multiple "Last login" messages if used
with
multiple sessions (none of my clients support it so I'm not sure about
that).

With my current plan for password expiry, loginmsg needs to be initialised 
before allowed_user() where it accumulates all of the "Your
password/account
will expire.." messages.

Might need to clear the message after retrieving/printing it.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=463

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #287 is|0                           |1
           obsolete|                            |



------- Additional Comments From dtucker at zip.com.au  2003-05-11 19:52 -------
Created an attachment (id=288)
 --> (http://bugzilla.mindrot.org/attachment.cgi?id=288&action=view)
Generate loginmsg as part of login recording (against OpenBSD -current, take 2)

Simpler patch, removes many of the Buffer->string->Buffer contortions.
Works
with multiple sessions (ie most recent login time is displayed each time).



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=463

dtucker at zip.com.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |14
              nThis|                            |





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.