openssh unix dev - Apr 2003 - [Bug 541] packet_set_interactive typo

http://bugzilla.mindrot.org/show_bug.cgi?id=541

           Summary: packet_set_interactive typo
           Product: Portable OpenSSH
           Version: -current
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: sshd
        AssignedTo: openssh-unix-dev at mindrot.org
        ReportedBy: furrier at iglou.com


Hi,

In OpenSSH 3.6.1p1, the function packet_set_interactive() in packet.c appears 
to have changed from 3.5p1.  It appears there may be a typographical error.

Specifically, 3.6.1p1 shows:

        /* Only set socket options if using a socket.  */
        if (!packet_connection_is_on_socket())
        if (interactive)
                set_nodelay(connection_in);

when it is probably supposed to say:

        /* Only set socket options if using a socket.  */
        if (!packet_connection_is_on_socket())
           return;
 
        if (interactive)
                set_nodelay(connection_in);

In other words, it appears somebody accidentily deleted the "return"
statement
that was present (and functional) in 3.5p1.  As such, the set_nodelay() only 
gets executed in 3.6.1p1 if the connection is NOT on a socket, which is likely 
not how it was meant to be written.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

http://bugzilla.mindrot.org/show_bug.cgi?id=541

mouring at eviladmin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From mouring at eviladmin.org  2003-04-28 03:56
-------
Correct it was a mistake from a merged patch.  It has been added back into
portable tree.
Thanks. 



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.