openssh unix dev - Feb 2002 - PATCH: nroff detection wrong, by default uses mantype=cat

Hi,

Just tested the latest snapshot on RHL72 via building RPM's of it.

Nroff detection was wrong, and if no --with-mantype was specified, the 
type would always revert to cat.  This one-byter fixes it.

-- 
Pekka Savola                 "Tell me of difficulties surmounted,
Netcore Oy                   not those you stumble over and fall"
Systems. Networks. Security.  -- Robert Jordan: A Crown of Swords
-------------- next part --------------
--- configure.ac~	Wed Feb 27 08:12:35 2002
+++ configure.ac	Wed Feb 27 18:43:45 2002
@@ -1798,7 +1798,7 @@
 	]
 )
 if test -z "$MANTYPE"; then
-	AC_PATH_PROGS(NROFF, nroff awf, /bin/false, /usr/bin:/usr/ucb)
+	AC_PATH_PROGS(NROFF, nroff awf, /bin/false, /usr/bin /usr/ucb)
 	if ${NROFF} -mdoc ${srcdir}/ssh.1 >/dev/null 2>&1; then
 		MANTYPE=doc
 	elif ${NROFF} -man ${srcdir}/ssh.1 >/dev/null 2>&1; then

On Wed, 27 Feb 2002, Pekka Savola wrote:
> Hi,
>
> Just tested the latest snapshot on RHL72 via building RPM's of it.
>
> Nroff detection was wrong, and if no --with-mantype was specified, the
> type would always revert to cat.  This one-byter fixes it.
Hmm...I get "Manpage Format: doc" with this patch under RH 7.2 without
this patch.

This was CVS snapshot as of a days ago when Tim was working on some
of the outstanding configure.ac bugs.

- Ben

On Wed, 27 Feb 2002, Pekka Savola wrote:
> Hi,
>
> Just tested the latest snapshot on RHL72 via building RPM's of it.
>
> Nroff detection was wrong, and if no --with-mantype was specified, the
> type would always revert to cat.  This one-byter fixes it.
>
-       AC_PATH_PROGS(NROFF, nroff awf, /bin/false, /usr/bin:/usr/ucb)
+       AC_PATH_PROGS(NROFF, nroff awf, /bin/false, /usr/bin /usr/ucb)


The test in configure.ac is correct.
If I test your patch with this striped down configure.ac it fails.
	AC_INIT
	AC_PATH_PROGS(NROFF, nroff awf, /bin/false, /usr/bin /usr/ucb)
	echo $NROFF
checking for nroff... no
checking for awf... no
/bin/false

Leaving the : in (remember, this is a PATH) it works correctly.
checking for nroff... /usr/bin/nroff
/usr/bin/nroff

Look in config.log to find out what is hapening on your system.

-- 
Tim Rice				Multitalents	(707) 887-1469
tim at multitalents.net