http://bugzilla.mindrot.org/show_bug.cgi?id=91 ------- Additional Comments From matthew at debian.org 2002-01-31 21:31 ------- Created an attachment (id=14) timeout patches (work by Ian Jackson and Matthew Vernon) ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
http://bugzilla.mindrot.org/show_bug.cgi?id=91 ------- Additional Comments From djm at mindrot.org 2002-01-31 21:51 ------- 1. This should really be two patches - protocol keepalives are a very different beast to connection timeouts. 2. Connection/read timeouts should use select() rather then alarm()+blocking ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
http://bugzilla.mindrot.org/show_bug.cgi?id=91 ------- Additional Comments From markus at openbsd.org 2002-01-31 22:53 ------- please try to have one feature per patch. 1. as to protocolkeepalive: isn't this what tcp-keepalives are for? 2. why use sigaction? sshd does a similar thing, but just uses alarm() 3. why not wrap exchange_indentification into alarm, like sshd does? 4. not all ssh1 implementations will accept your ignore message ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.