openssh unix dev - Oct 2001 - OpenSSH-3.0p1-pre-CVS: configure.ac checks for login in -lutil and -lbsd?

OpenSSH-3.0p1-pre, from CVS as of about 2001-10-30 23:45 UTC.

Any particular reason why configure is checking for login() in -lutil,
finds it, then checks for it again in -lbsd?

Here's the relevant excerpts (Red Hat Linux 6.2, , kernel-2.2.19,
glibc-2.1.3, egcs-1.1.2, autoconf-2.52):

  $ CFLAGS='-O2 -mpentium -Wall'; export CFLAGS
  $ ./configure --prefix=/usr/local/encap/openssh_cvs-2001.10.30.2345UTC
  ...
  checking for yp_match... no
  checking for yp_match in -lnsl... yes
  checking for setsockopt... yes
  checking for getspnam... yes
  checking for login... no
  checking for login in -lutil... yes   <--- #define HAVE_LIBUTIL_LOGIN
              ^^^^^^^^^^^^^^^^^^^^^^^^
  checking for deflate in -lz... yes
  ...
  checking for libutil.h... no
  checking for login... (cached) no
              ^^^^^^^^^^^^^^^^^^^^^^
  checking for logout... yes
  checking for updwtmp... yes
  checking for logwtmp... yes
  ...
  checking for getuserattr... no
  checking for getuserattr in -ls... no
  checking for login... (cached) no
              ^^^^^^^^^^^^^^^^^^^^^^
  checking for login in -lbsd... yes    <--- #define HAVE_LOGIN
              ^^^^^^^^^^^^^^^^^^^^^^^
  checking for daemon... yes
  ...
  OpenSSH has been configured with the following options:
                   User binaries:
/usr/local/encap/openssh_cvs-2001.10.30.2345UTC/bin
                 System binaries:
/usr/local/encap/openssh_cvs-2001.10.30.2345UTC/sbin
             Configuration files:
/usr/local/encap/openssh_cvs-2001.10.30.2345UTC/etc
                 Askpass program:
/usr/local/encap/openssh_cvs-2001.10.30.2345UTC/libexec/ssh-askpass
                    Manual pages:
/usr/local/encap/openssh_cvs-2001.10.30.2345UTC/man/manX
                        PID file: /var/run
          sshd default user PATH:
/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/encap/openssh_cvs-2001.10.30.2345UTC/bin
        Random number collection: Device (/dev/urandom)
                  Manpage format: doc
                     PAM support: no
              KerberosIV support: no
               Smartcard support: no
                     AFS support: no
                   S/KEY support: no
            TCP Wrappers support: no
            MD5 password support: no
     IP address in $DISPLAY hack: no
        Use IPv4 by default hack: no
         Translate v4 in v6 hack: yes
  
                Host: i586-pc-linux-gnu
            Compiler: egcs -pipe
      Compiler flags: -O2 -mpentium -Wall -Wall -Wpointer-arith
-Wno-uninitialized
  Preprocessor flags: 
        Linker flags: 
           Libraries: -lz -lnsl  -lutil -lbsd -lcrypto -lcrypt 
                                ^^^^^^^^^^^^^^

Shouldn't finding login() in -lutil define both HAVE_LIBUTIL_LOGIN and
HAVE_LOGIN?  Or am i missing something?

-- 
jim knoble | jmknoble at pobox.com   | http://www.pobox.com/~jmknoble/
(GnuPG fingerprint: 31C4:8AAC:F24E:A70C:4000::BBF4:289F:EAA8:1381:1491)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 262 bytes
Desc: not available
Url :
http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20011030/2d95dfd2/attachment.bin

On Tue, 30 Oct 2001, Jim Knoble wrote:
> OpenSSH-3.0p1-pre, from CVS as of about 2001-10-30 23:45 UTC.
>
> Any particular reason why configure is checking for login() in -lutil,
> finds it, then checks for it again in -lbsd?
>
[snip]
> Shouldn't finding login() in -lutil define both HAVE_LIBUTIL_LOGIN and
> HAVE_LOGIN?  Or am i missing something?
>
Hmm, HAVE_LIBUTIL_LOGIN isn't used anywhere in the source.

Try this patch.

------------< cut >------------
--- acconfig.h.old	Sun Oct 21 17:53:59 2001
+++ acconfig.h	Tue Oct 30 17:57:48 2001
@@ -178,9 +178,6 @@
 /* Define if you want to specify the path to your wtmpx file */
 #undef CONF_WTMPX_FILE

-/* Define is libutil has login() function */
-#undef HAVE_LIBUTIL_LOGIN
-
 /* Define if you want external askpass support */
 #undef USE_EXTERNAL_ASKPASS

--- configure.ac.old	Sat Oct 27 10:45:37 2001
+++ configure.ac	Tue Oct 30 18:03:07 2001
@@ -370,9 +370,6 @@

 AC_CHECK_FUNC(getspnam, ,
 	AC_CHECK_LIB(gen, getspnam, LIBS="$LIBS -lgen"))
-AC_CHECK_FUNC(login, ,
-	AC_CHECK_LIB(util, login,
-		AC_DEFINE(HAVE_LIBUTIL_LOGIN) LIBS="$LIBS -lutil"))

 dnl zlib is required
 AC_ARG_WITH(zlib,
@@ -619,7 +616,7 @@
 AC_CHECK_FUNCS(gettimeofday time)
 dnl    Checks for libutil functions
 AC_CHECK_HEADERS(libutil.h)
-AC_CHECK_FUNCS(login logout updwtmp logwtmp)
+AC_CHECK_FUNCS(logout updwtmp logwtmp)
 dnl    Checks for utmp functions
 AC_CHECK_FUNCS(endutent getutent getutid getutline pututline setutent)
 AC_CHECK_FUNCS(utmpname)
@@ -634,7 +631,9 @@

 AC_CHECK_FUNC(login,
 	[AC_DEFINE(HAVE_LOGIN)],
+	[AC_CHECK_LIB(util, login, AC_DEFINE(HAVE_LOGIN) LIBS="$LIBS
-lutil",
 	[AC_CHECK_LIB(bsd, login, [LIBS="$LIBS -lbsd";
AC_DEFINE(HAVE_LOGIN)])]
+	)]
 )

 AC_CHECK_FUNC(daemon,
------------< end cut >------------

-- 
Tim Rice				Multitalents	(707) 887-1469
tim at multitalents.net