openssh unix dev - Dec 2000 - implicit declaration warnings

Hi,

When I tested the latest snapshot on FreeBSD 4.2, I noticed some implicit
declaration warnings I didn't recall seeing on Linux.

I think this is caused by the fact that if autoconf does detect the
presence of some BSD capability, necessary header files and declarations
may not be included (as these are assumed to be the same ~everywhere, and
already included).  If such capability is missing, everything will seem to
be fine.

E.g.:
---
uuencode.c: In function `uuencode':
uuencode.c:36: warning: implicit declaration of function `__b64_ntop'
uuencode.c: In function `uudecode':
uuencode.c:54: warning: implicit declaration of function `__b64_pton'
auth-rhosts.c: In function `check_rhosts_file':
auth-rhosts.c:110: warning: implicit declaration of function `innetgr'
loginrec.c: In function `syslogin_perform_login':
loginrec.c:1282: warning: implicit declaration of function `login'
loginrec.c: In function `syslogin_perform_logout':
loginrec.c:1295: warning: implicit declaration of function `logout'
loginrec.c:1299: warning: implicit declaration of function `logwtmp'
---

In config.h, there are:
#define HAVE___B64_NTOP 1
#define HAVE_LIBUTIL_LOGIN 1
#define HAVE_INNETGR 1

Attached patch removes the warnings about login functions BUT will break
on systems that define LIBUTIL_LOGIN but don't have libutil.h (e.g.
Linux).  So, it's not the way to go.  But some sort of "nice" way
of
handling the necessary includes should probably be used?

-- 
Pekka Savola                    "Tell me of difficulties surmounted,
Netcore Oy                      not those you stumble over and fall"
Systems. Networks. Security.     -- Robert Jordan: A Crown of Swords
-------------- next part --------------
--- loginrec.c.orig	Fri Dec  1 23:19:51 2000
+++ loginrec.c	Wed Dec 27 13:06:12 2000
@@ -167,6 +167,10 @@
 #  include <util.h>
 #endif
 
+#ifdef HAVE_LIBUTIL_LOGIN
+#  include <libutil.h>
+#endif
+
 /**
  ** prototypes for helper functions in this file
  **/

On Wed, 27 Dec 2000, Pekka Savola wrote:
> Hi,
> 
> When I tested the latest snapshot on FreeBSD 4.2, I noticed some implicit
> declaration warnings I didn't recall seeing on Linux.
> 
Hmm.. I think the following patch may be what you wanted.  

- Ben

--- ../openssh/loginrec.c	Fri Dec  1 15:19:51 2000
+++ loginrec.c	Wed Dec 27 13:11:13 2000
@@ -167,6 +167,10 @@
 #  include <util.h>
 #endif
 
+#ifdef HAVE_LIBUTIL_H
+#   include <libutil.h>
+#endif
+
 /**
  ** prototypes for helper functions in this file
  **/
--- ../openssh/configure.in	Wed Dec 27 00:52:07 2000
+++ configure.in	Wed Dec 27 13:08:18 2000
@@ -309,6 +308,7 @@
 dnl    Checks for time functions
 AC_CHECK_FUNCS(gettimeofday time)
 dnl    Checks for libutil functions
+AC_CHECK_HEADERS(libutil.h)
 AC_CHECK_FUNCS(login logout updwtmp logwtmp)
 dnl    Checks for utmp functions
 AC_CHECK_FUNCS(endutent getutent getutid getutline pututline setutent)

On Wed, 27 Dec 2000, Pekka Savola wrote:
: auth-rhosts.c:110: warning: implicit declaration of function `innetgr'

is there a standard place for the proto for innetgr()?  openbsd has
<netgroup.h>; linux has <netdb.h>; HP-UX doesn't define a
prototype at
all (i'll submit a defect).

btw, unless i'm missing something, i think we want this:

--- ../../openssh-2.3.0p1/includes.h	Wed Oct 18 02:02:25 2000
+++ includes.h	Thu Dec 28 03:55:37 2000
@@ -32,7 +32,6 @@
 #include <netinet/tcp.h>
 #endif
 #include <arpa/inet.h>
-#include <netdb.h>
 
 #include <stdio.h>
 #include <ctype.h>