openssh unix dev - Mar 2001 - ssh-add won't look for id_dsa in ssh-clients-2.3.0p1-4 but did in ssh-clients-2.5.1p2-1

I've been running ssh-clients-2.3.0p1-4 on RedHat 7.0 and upgraded to
2.5.1p2-1 yesterday from 
ftp://ftp.openbsd.org/pub/OpenBSD/OpenSSH/portable/rpm/SRPMS/.

I noticed that 2.5.1p2-1 ssh-add won't look for id_dsa.pub by default --
if I have no
identity file it just says "/home/klotz/.ssh/identity: No such file or
directory"

The 2.5.1p1-1 I got from RedHat's rawhide site *does* look for it.  Is
this a RedHat patch?

It works if I explicitly specify /home/klotz/.ssh/id_dsa.pub

I looked in ssh-add.c from openssh-2.5.1p2-1.src.rpm from the OpenBSD
rpm directory mentioned above,
and I see that at line 295 it looks in _PATH_SSH_CLIENT_IDENTITY
but no further.  I see that readconf.c in line 810 does check
options->protocol && SSH_PROTO_2
and will also check _PATH_SSH_CLIENT_ID_DSA, but this logic is not
present in ssh-add.

Since I don't have the CVS tree, I couldn't check to see if this log was
previously present in
ssh-add.c or not, or if it is a RedHat patch.  Am I broken in some way
to expect ssh-add simply
to work with id_dsa without an explicit argument?

Leigh.

On Thu, Mar 01, 2001 at 02:10:49PM -0800, Leigh L. Klotz, Jr.
wrote:
> Am I broken in some way
> to expect ssh-add simply
> to work with id_dsa without an explicit argument?
no, you are not. but ssh-add did not add the keys before.
should a default behaviour be changed?

apart from that, i don't like 'ssh-add' having default
arguments. people forget where the private keys can be
found if 'ssh-add' acts 'smart'. keys should always be
explicit since they are important. but i could be wrong.

-m