openssh unix dev - Dec 2000 - Point in usernames / scp

Hi,

we are using usernames on our systems that contain a point '.', like
"r.john".

We found it necessary to patch the source to make the "scp" command
work
with those usernames.

Cheers
Kai

--- openssh-2.2.0p1/scp.c	Wed Aug 30 01:11:30 2000
+++ withpoint/scp.c	Mon Dec 11 02:06:35 2000
@@ -1042,7 +1042,7 @@
 		c = *cp;
 		if (c & 0200)
 			goto bad;
-		if (!isalpha(c) && !isdigit(c) && c != '_' &&
c != '-')
+		if (!isalpha(c) && !isdigit(c) && c != '_' &&
c != '-' && c != '.')
 			goto bad;
 	} while (*++cp);
 	return (1);

Kai Engert <engert at isg.de> writes:
> -		if (!isalpha(c) && !isdigit(c) && c != '_'
&& c != '-')
> +		if (!isalpha(c) && !isdigit(c) && c != '_'
&& c != '-' && c != '.')
If you are at it, you couuld also include '+' here.

-- 
Florian Weimer 	                  Florian.Weimer at RUS.Uni-Stuttgart.DE
University of Stuttgart           http://cert.uni-stuttgart.de/
RUS-CERT                          +49-711-685-5973/fax +49-711-685-5898

On Mon, 11 Dec 2000, Kai Engert wrote:
: we are using usernames on our systems that contain a point '.', like
: "r.john".
: 
: We found it necessary to patch the source to make the "scp" command
work
: with those usernames.
: 
: Cheers
: Kai
: 
: --- openssh-2.2.0p1/scp.c	Wed Aug 30 01:11:30 2000
: +++ withpoint/scp.c	Mon Dec 11 02:06:35 2000
: @@ -1042,7 +1042,7 @@
:  		c = *cp;
:  		if (c & 0200)
:  			goto bad;
: -		if (!isalpha(c) && !isdigit(c) && c != '_'
&& c != '-')
: +		if (!isalpha(c) && !isdigit(c) && c != '_'
&& c != '-' && c != '.')
:  			goto bad;
:  	} while (*++cp);
:  	return (1);

That change was intended a while back, but didn't get fully applied;
it's now in the CVS tree.