similar to: Point in usernames / scp

http://bugzilla.mindrot.org/show_bug.cgi?id=377 Summary: Reduce compiler warnings. Use unsigned args to the ctype.h is*() macros. Product: Portable OpenSSH Version: -current Platform: Sparc OS/Version: Solaris Status: NEW Severity: trivial Priority: P2 Component: Miscellaneous

Ok, here is the patch again... I also included fixes for the bits that originally gave my mailer fits... Two votes for orange, so I went with orange... Doing diffs in .: --- ./lib/AsmParser/LLLexer.cpp.~1~ 2007-12-14 22:09:06.000000000 -0800 +++ ./lib/AsmParser/LLLexer.cpp 2007-12-15 13:02:47.000000000 -0800 @@ -54,7 +54,7 @@ static uint64_t HexIntToVal(const char * Result +=

This is needed as the basis for the readlink -f option. Signed-off-by: Ben Hutchings <ben at decadent.org.uk> --- --- a/usr/include/stdlib.h +++ b/usr/include/stdlib.h @@ -92,4 +92,6 @@ static __inline__ int grantpt(int __fd) return 0; /* devpts does this all for us! */ } +__extern char *realpath(const char *, char *); + #endif /* _STDLIB_H */ --- a/usr/klibc/Kbuild +++

In several places, openssh-2.9.9p2 passes a 'char' value to a ctype macro like 'isdigit'. This has undefined behavior on hosts with signed characters, if the character value happens to be negative. For example, isdigit('\200') expands to an array access that is a subscript error on hosts with signed characters where '\200' == -128. This leads to incorrect results,

Hi While ssh allows for usernames containing a dot, scp gives an error "Invalid user name". The following patch fixed that behaviour: diff -ru scp.c-save scp.c --- scp.c-save Thu Mar 9 12:21:43 2000 +++ scp.c Thu Mar 9 12:22:25 2000 @@ -1062,7 +1062,7 @@ c = *cp; if (c & 0200) goto bad; - if (!isalpha(c) && !isdigit(c) && c !=

Hi everyone, I found that Clang -O0 performs optimizations that undermine dynamic bug-finding tools. First, most bug finding tools such as ASan, Valgrind, Dr. Memory, Mudflap, Purify and Safe Sulong (on which I am working) rely on detecting errors during the execution of the program. They either insert additional checks during compile-time or during run-time which are executed when the program

Newer g++ compilers can emit: /Volumes/mrs5/net/llvm/llvm/llvm/lib/AsmParser/LLLexer.cpp: In member function 'int llvm::LLLexer::LexAt()': /Volumes/mrs5/net/llvm/llvm/llvm/lib/AsmParser/LLLexer.cpp:287: warning: suggest a space before ';' or explicit braces around empty body in 'for' statement /Volumes/mrs5/net/llvm/llvm/llvm/lib/AsmParser/LLLexer.cpp: In member

On Dec 15, 2007, at 2:13 AM, Duncan Sands wrote: > Hi, > >> - for (++CurPtr; isdigit(CurPtr[0]); ++CurPtr); >> + for (++CurPtr; isdigit(CurPtr[0]); ++CurPtr) ; > > personally I like > > for (++CurPtr; isdigit(CurPtr[0]); ++CurPtr) {} > > better since it is more explicit. I think the bikeshed should be orange: for (++CurPtr; isdigit(CurPtr[0]);

Hi, > - for (++CurPtr; isdigit(CurPtr[0]); ++CurPtr); > + for (++CurPtr; isdigit(CurPtr[0]); ++CurPtr) ; personally I like for (++CurPtr; isdigit(CurPtr[0]); ++CurPtr) {} better since it is more explicit. Ciao, Duncan.

Posting to the list first, rather than filing a bug because I'm not sure this is still an intended configuration: With LLVM configured as: CXX=clang++ CC=clang cmake ../llvm/ \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_INSTALL_PREFIX=~/install/llvm-master/ \ -DLLVM_TARGETS_TO_BUILD=host \ -DLLVM_ENABLE_ASSERTIONS=true \ -DLLVM_ENABLE_LIBCXX=yes \ -DLLVM_ENABLE_LIBCXXABI=yes The check-all target

Hi, OpenSSH 5.6 is almost ready for release, so we would appreciate testing on as many platforms and systems as possible. This is a moderately large release, with a number of new features and bug fixes. Snapshot releases for portable OpenSSH are available from http://www.mindrot.org/openssh_snap/ The OpenBSD version is available in CVS HEAD: http://www.openbsd.org/anoncvs.html Portable OpenSSH

>> ------------------------ >> R & R, any comments? >> ------------------------ At present the parser makes the decision on what characters can go into symbol names based on isalpha(c). If someone will send me a function - say isidchar(c) which returns 1 for characters which can be in identifiers and 0 otherwise, I will replace the current test with that. Ross

Hi OpenSSH developers In the source file *scp.c* there is a function called *okname(char *cp0)* that validates the entered username by using the scp command as follows: * *[ Fragment scp.c start ] ... int okname(char *cp0) { int c; char *cp; cp = cp0; do { c = (int)*cp; if (c & 0200) goto bad; if (!isalpha(c) &&

Me again, Here's a patch to fix ctypes. There was an off-by-one correction that looks like it isn't needed. Boundary conditions and single-entry items, like isspace(), now work for me. mh -- Martin Hicks Wild Open Source Inc. mort@wildopensource.com 613-266-2296 # This is a BitKeeper generated patch for the following project: # Project Name: The kernel C library

This is needed as the basis for the readlink -f option. Signed-off-by: Ben Hutchings <ben at decadent.org.uk> --- v2: Don't implement the BSD/GNU extension of allowing a non-existent last part. Use open(O_PATH) and procfs to get resolved name from the kernel. --- a/usr/include/stdlib.h +++ b/usr/include/stdlib.h @@ -92,4 +92,6 @@ static __inline__ int grantpt(int __fd) return

Dear llvmers, I decided to write my own scripts to compile the SPEC programs, and they work fine, except with 403.gcc. Basically, I take the file 403.gcc.linked.rbc from the ...\Output folder that the LLVM test suite produces. Then I use this linked.rbc file to generate an executable file via the following commands: llc 403.gcc.linked.rbc -o 403.gcc.linked.s clang 403.gcc.linked.s -o

Why does the local scp determine what characters are valid in a remote host userid? A friend of mine just had his ISP convert him to using a userid of the form 'user#isp-acct' (eg, "ssh -l 'joe#foo.org' foo.org" is used to login). The OpenSSH ssh and sftp commands both allow this form of userid. However, it seems that scp has its very own idea of what characters are

In 0.97 io.h is wrong in several places. it should be returning __v, not v. static __inline__ unsigned char inb(unsigned short __p) { unsigned char __v; asm volatile("inb %1,%0" : "=a" (__v) : "dN" (__p)); return v; } How do I get rid of these warnings? /home/mesa/boot/klibc/klibc/include/stdlib.h:21: warning: shadowing built-in function `abs'

Hi, Per the definitions of the ctype functions in POSIX-1.2008 "the c argument is an int, the value of which the application shall ensure is a character representable as an unsigned char or equal to the value of the macro EOF. If the argument has any other value, the behavior is undefined." For obvious reasons this results in problems if you use signed char variables as parameters in

Commit-ID: 32b36eb98fafad924f3f69904d74d2f2168a4753 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=32b36eb98fafad924f3f69904d74d2f2168a4753 Author: Ben Hutchings <ben at decadent.org.uk> AuthorDate: Wed, 6 Jan 2016 01:08:47 +0000 Committer: H. Peter Anvin <hpa at linux.intel.com> CommitDate: Tue, 5 Jan 2016 17:48:43 -0800 [klibc] Implement realpath() This