openssh bugs - Mar 2024 - [Bug 3673] New: -fzero-call-used-regs=used detection fails on Linux m68k with GCC 13

https://bugzilla.mindrot.org/show_bug.cgi?id=3673

            Bug ID: 3673
           Summary: -fzero-call-used-regs=used detection fails on Linux
                    m68k with GCC 13
           Product: Portable OpenSSH
           Version: 9.7p1
          Hardware: 68k
               URL: https://bugs.debian.org/1067243
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Build system
          Assignee: unassigned-bugs at mindrot.org
          Reporter: cjwatson at debian.org

Created attachment 3797
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3797&action=edit
Extend -fzero-call-used-regs check to catch m68k gcc bug

Thorsten Glaser reported that there's an ICE in GCC 13 on Linux m68k
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110934) that's missed by
the autoconf machinery to detect whether -fzero-call-used-regs=used is
usable.  The attached patch beefs up the autoconf check a bit more so
that it notices this.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3673

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3674
         Resolution|---                         |FIXED
                 CC|                            |dtucker at dtucker.net
             Status|NEW                         |RESOLVED

--- Comment #1 from Darren Tucker <dtucker at dtucker.net> ---
Patch applied (both master and 9.7 branch) so it will be in the next
release.

Thanks for the report.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3674
[Bug 3674] Tracking bug for OpenSSH 9.8
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3673

Jessie <mia.lyon26 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mia.lyon26 at gmail.com

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3673

Colin Watson <cjwatson at debian.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #2 from Colin Watson <cjwatson at debian.org> ---
Frustratingly, this patch somehow managed to regress behaviour on
Debian ppc64el (see
https://buildd.debian.org/status/fetch.php?pkg=openssh&arch=ppc64el&ver=1%3A9.7p1-3&stamp=1711920599&file=log;
also compare https://bugzilla.mindrot.org/show_bug.cgi?id=3645).  I can
run test code on this architecture, but I have no idea how adding this
extra code to this check made the check somehow pass on ppc64el when it
should have failed.

I don't suppose this check could be wrapped in AC_CACHE_CHECK somehow? 
Then, rather than bothering you with extra portability checks that
nobody really seems to understand, I could just brute-force it by
passing ac_cv_whatever=no to configure on the relevant architectures. 
I don't really want to take up a bunch of your time figuring this
nonsense out ...

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3673

--- Comment #3 from Colin Watson <cjwatson at debian.org> ---
Created attachment 3803
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3803&action=edit
Add Autoconf cache variables for OSSH_CHECK_*FLAG_*

How about this?  Briefly tested, but it seems to do the job.  For
example:

  $ ./configure ossh_cv_cflag__fzero_call_used_regs_used=no
  [...]
  checking if cc supports compile flag -ftrapv and linking succeeds...
yes
  checking if cc supports compile flag -fzero-call-used-regs=used and
linking succeeds... (cached) no
  checking if cc supports compile flag -ftrivial-auto-var-init=zero...
yes

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3673

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3708


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3708
[Bug 3708] Tracking bug for OpenSSH 9.9
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3673

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|3674                        |


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3674
[Bug 3674] Tracking bug for OpenSSH 9.8
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3673

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|3708                        |


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3708
[Bug 3708] Tracking bug for OpenSSH 9.9
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3673

raphael.melotte at mind.be changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |raphael.melotte at mind.be

--- Comment #4 from raphael.melotte at mind.be ---
I can see the same issue for powerpc64le in Buildroot:
https://autobuild.buildroot.org/results/4d2/4d2aee9edc37fb488d346c3922e2f5ca12c55c5e//build-end.log

Did anyone figure out a solution in the meantime?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3673

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
   Attachment #3803|                            |ok?(dtucker at dtucker.net)
              Flags|                            |

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
Comment on attachment 3803
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3803
Add Autoconf cache variables for OSSH_CHECK_*FLAG_*

This looks ok to me (though I had to reread the autoconf manual).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3673

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3803|ok?(dtucker at dtucker.net)    |ok+
              Flags|                            |

--- Comment #6 from Darren Tucker <dtucker at dtucker.net> ---
Comment on attachment 3803
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3803
Add Autoconf cache variables for OSSH_CHECK_*FLAG_*

(In reply to Damien Miller from comment #5)
[...]
> This looks ok to me (though I had to reread the autoconf manual).
Condolences.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3673

--- Comment #7 from Damien Miller <djm at mindrot.org> ---
Patch applied as 29cf521486bf and will be in OpenSSH 10.1

Raphael, I think Colin's patch can be used to skip this flag on the
affected platform, though I wouldn't call it a solution. We'd need to
see the contents of config.log to see what has happened.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3673

--- Comment #8 from raphael.melotte at mind.be ---
Thanks Damien!

The config.log is available at:
https://autobuild.buildroot.org/results/4d2/4d2aee9edc37fb488d346c3922e2f5ca12c55c5e/openssh-9.9p2/config.log

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.