openssh bugs - Dec 2023 - [Bug 3645] New: -fzero-call-used-regs=used detection seems to fail on Linux ppc64el

https://bugzilla.mindrot.org/show_bug.cgi?id=3645

            Bug ID: 3645
           Summary: -fzero-call-used-regs=used detection seems to fail on
                    Linux ppc64el
           Product: Portable OpenSSH
           Version: 9.6p1
          Hardware: PPC64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Build system
          Assignee: unassigned-bugs at mindrot.org
          Reporter: cjwatson at debian.org

9.6p1 failed to build on Debian ppc64(el) with this error:

  ../../cipher.c: In function ?compression_alg_list?:
  ../../cipher.c:151:1: sorry, unimplemented: argument ?used? is not
supported for ?-fzero-call-used-regs? on this target
    151 | }
        | ^

A complete build log is at
https://buildd.debian.org/status/fetch.php?pkg=openssh&arch=ppc64el&ver=1%3A9.6p1-1&stamp=1702942848&raw=0.

I have a shell on a relevant machine and am happy to try adding more
things to the conftest.c code that tries to provoke this sort of error,
but I'm not quite sure what to try for myself.  Any suggestions?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3645

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Created attachment 3776
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3776&action=edit
better detection of broken compiler maybe?

AFAIK this is a gcc bug and it's super weird that this one, trivial,
function elicits it but nothing else.

This extends the autoconf test that we use to detect broken compilers
to do something similar to the function in question. Can you see if it
works? I don't have a ppc-anything box around to test with.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3645

--- Comment #2 from Colin Watson <cjwatson at debian.org> ---
sshkey_set_filename (in the branch where WITH_XMSS is false) in
sshkey.c elicits it as well, according to the build log.

That extended autoconf test seems to do the trick, thanks!

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3645

bbhtt.zn0i8 at slmail.me changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bbhtt.zn0i8 at slmail.me

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3645

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
thanks - committed (on master and on the V_9_6 stable branch)

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.