openssh bugs - Jul 2023 - [Bug 3589] New: ControlMaster auto, persist and -f fail.

https://bugzilla.mindrot.org/show_bug.cgi?id=3589

            Bug ID: 3589
           Summary: ControlMaster auto, persist and -f fail.
           Product: Portable OpenSSH
           Version: 9.3p1
          Hardware: amd64
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: peter.chubb at unsw.edu.au

Created attachment 3706
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3706&action=edit
ssh -v -f -X somehost xterm

In my ~/.ssh/config I have:

Host *
     ControlMaster auto
     ControlPersist 300
     ControlPath /home/%u/.ssh/controlmaster/%h-%p-%r.sock
     ServerAliveInterval 60
     TCPKeepAlive yes

Doing:
  ssh -X -f somehost xterm

does not start an xterm the first time it is run.
Repeating the command does start an xterm.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3589

--- Comment #1 from Peter Chubb <peter.chubb at unsw.edu.au> ---
Created attachment 3708
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3708&action=edit
Possible fix.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3589

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
that seems to help insofar as xclock now runs, but it doesn't
background properly. It's been a while since I've touched this code,
but IIRC for ControlPersist the command should be run by the forked
client of the mux process and I'm not convinced that's happening right
in this case.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3589

--- Comment #3 from Peter Chubb <peter.chubb at unsw.edu.au> ---
For that you need the new patch I appended to
https://bugzilla.mindrot.org/show_bug.cgi?id=1948

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3589

--- Comment #4 from Peter Chubb <peter.chubb at unsw.edu.au> ---
https://bugzilla.mindrot.org/attachment.cgi?id=3705

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3589

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org
             Status|NEW                         |ASSIGNED

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
Created attachment 3709
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3709&action=edit
Fix -f in mux client mode

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3589

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at dtucker.net
   Attachment #3709|                            |ok?(dtucker at dtucker.net)
              Flags|                            |

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3589

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3709|ok?(dtucker at dtucker.net)    |ok+
              Flags|                            |

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3589

--- Comment #6 from Peter Chubb <peter.chubb at unsw.edu.au> ---
Yay!  the latest patch seems to work (more consistently than my
half-baked ones anyway)

Thanks!

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3589

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3549
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Damien Miller <djm at mindrot.org> ---
Applied in 2d34205dab08e and will be in OpenSSH 9.4, due in a couple of
weeks. Thanks!


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3549
[Bug 3549] Tracking bug for OpenSSH 9.4
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.