openssh bugs - Jan 2022 - [Bug 3379] New: Config parser only allows SetEnv once

https://bugzilla.mindrot.org/show_bug.cgi?id=3379

            Bug ID: 3379
           Summary: Config parser only allows SetEnv once
           Product: Portable OpenSSH
           Version: 8.8p1
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: bugzilla at streibelt.net

When using SetEnv in the .ssh/config it can only be used once.

Every additional entry will be ignored.

looking at readconf.c:1758 I see that options->num_setenv is being
checked to be != 0 and then continuing.

This leads to these configurations NOT to work as intended:

SetEnv TZ=UTC
SetEnv TERM=xterm

Here only TZ will be set.

Also when SetEnv is being used globally, it cannot be used later inside
a Host definition to specify additional variables or change them.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3379

Florian Streibelt <bugzilla at streibelt.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at streibelt.net

--- Comment #1 from Florian Streibelt <bugzilla at streibelt.net> ---
Created attachment 3564
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3564&action=edit
working proof of concept patch

Just a quick and dirty proof of concept, that allows overwriting the
environment in a host definition and also using multiple SetEnv entries
to set different env vars.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3379

github at kalvdans.no-ip.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |github at kalvdans.no-ip.org

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3379

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
                 CC|                            |djm at mindrot.org
             Status|NEW                         |RESOLVED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
This is completely intentional. You can put multiple SetEnv on the same
line.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.