openssh bugs - Oct 2020 - [Bug 3222] New: get -r doesn't work because directories are created without write permissions

https://bugzilla.mindrot.org/show_bug.cgi?id=3222

            Bug ID: 3222
           Summary: get -r doesn't work because directories are created
                    without write permissions
           Product: Portable OpenSSH
           Version: 8.1p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: sftp
          Assignee: unassigned-bugs at mindrot.org
          Reporter: ncdehnel at gmail.com

nathan at gentooserver /media/store/Data/VM/OpenVMS/OPENKITS $ sftp -o
PasswordAuthentication=yes OPENKITS at vsiftp.vmssoftware.com

 This is VMS Software, Inc. OpenVMS (TM) IA64 Operating System,
V8.4-2L1
OPENKITS at vsiftp.vmssoftware.com's password: 
Connected to vsiftp.vmssoftware.com.
sftp> ls   
ALPOPENSOURCE  I64OPENSOURCE  README.TXT     
sftp> get -r ALPOPENSOURCE
Fetching /disk$guest03/OPENKITS/ALPOPENSOURCE/ to ALPOPENSOURCE
Retrieving /disk$guest03/openkits/alpopensource
Retrieving /disk$guest03/openkits/alpopensource/ARCHIVE
mkdir ALPOPENSOURCE/ARCHIVE: Permission denied
Couldn't open local file
"ALPOPENSOURCE/SYSLOGD-AXPVMS-04-FEB-2018.TXT"
for writing: Permission denied
Download of file
/disk$guest03/openkits/alpopensource/SYSLOGD-AXPVMS-04-FEB-2018.TXT to
ALPOPENSOURCE/SYSLOGD-AXPVMS-04-FEB-2018.TXT failed

nathan at gentooserver /media/store/Data/VM/OpenVMS/OPENKITS $ ls -l
total 4
dr--r----- 1 nathan nathan   0 Oct 20 15:28 ALPOPENSOURCE
dr--r----- 1 nathan nathan   0 Oct 20 15:28 I64OPENSOURCE
-rw-r--r-- 1 nathan nathan 675 Oct 20 15:28 README.TXT

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3222

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at dtucker.net

--- Comment #1 from Darren Tucker <dtucker at dtucker.net> ---
This is because the source directories are not writable either, and
sftp is maintaining those permissions:
sftp> ls -l
dr--r-----   1 ECOKITS  VSI$GUEST     4096 Oct 26  2016 ALPOPENSOURCE
dr--r-----   1 ECOKITS  VSI$GUEST     9216 Apr 19  2016 I64OPENSOURCE
-r--r--r--   1 OPENKITS VSI$GUEST      706 Jan 29  2019 README.TXT

sftp would need to open the directory with user write, then set the
final permission when it's done with the directory.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3222

--- Comment #2 from Darren Tucker <dtucker at dtucker.net> ---
oh, and the directory doesn't have the "x" bit, which is also
going to
cause some problems on most unix variants.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3222

--- Comment #3 from Darren Tucker <dtucker at dtucker.net> ---
Created attachment 3450
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3450&action=edit
Ensure directory is writable and searchable for the duration of a
recursive transfer

Please try this patch.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3222

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3217


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=3217
[Bug 3217] Tracking bug for 8.5 release
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3222

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3450|0                           |1
        is obsolete|                            |

--- Comment #4 from Darren Tucker <dtucker at dtucker.net> ---
Created attachment 3451
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3451&action=edit
Ensure directory is writable and searchable for the duration of a
recursive transfer

fix incorrect error message in previous.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3222

--- Comment #5 from ncdehnel at gmail.com ---
The patch seems to work. It seems to have downloaded all the files.
Thank you.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3222

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Darren Tucker <dtucker at dtucker.net> ---
The patch (plus the equivalent for the upload path) has been committed
and will be in the 8.5 release.  Thanks for the report.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=3222

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.