openssh bugs - Jul 2017 - [Bug 2748] New: Bug compatibility masks incorrectly match WinSCP 5.10.x

https://bugzilla.mindrot.org/show_bug.cgi?id=2748

            Bug ID: 2748
           Summary: Bug compatibility masks incorrectly match WinSCP
                    5.10.x
           Product: Portable OpenSSH
           Version: 7.5p1
          Hardware: Other
                OS: Other
            Status: NEW
          Severity: normal
          Priority: P5
         Component: sshd
          Assignee: unassigned-bugs at mindrot.org
          Reporter: martin at winscp.net

The compat_datafellows function in compat.c includes this rule:

                { "WinSCP_release_4*,"
                  "WinSCP_release_5.0*,"
                  "WinSCP_release_5.1*,"
                  "WinSCP_release_5.5*,"
                  "WinSCP_release_5.6*,"
                  "WinSCP_release_5.7,"
                  "WinSCP_release_5.7.1,"
                  "WinSCP_release_5.7.2,"
                  "WinSCP_release_5.7.3,"
                  "WinSCP_release_5.7.4",
                                        SSH_OLD_DHGEX },

Unfortunately the "WinSCP_release_5.1*" mask inadvertently matches
even
the latest branch of WinSCP 5.10 with version string like
"WinSCP_release_5.10.4".

Can you please change the masks to require a dot?

                { "WinSCP_release_4*,"
                  "WinSCP_release_5.0,"
                  "WinSCP_release_5.0.*,"
                  "WinSCP_release_5.1,"
                  "WinSCP_release_5.1.*,"
                  "WinSCP_release_5.5,"
                  "WinSCP_release_5.5.*,"
                  "WinSCP_release_5.6,"
                  "WinSCP_release_5.6.*,"
                  "WinSCP_release_5.7,"
                  "WinSCP_release_5.7.1,"
                  "WinSCP_release_5.7.2,"
                  "WinSCP_release_5.7.3,"
                  "WinSCP_release_5.7.4",
                                        SSH_OLD_DHGEX },

Thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2748

Martin Prikryl <martin at winscp.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Bug compatibility masks     |Bug compatibility rules
                   |incorrectly match WinSCP    |incorrectly match WinSCP
                   |5.10.x                      |5.10.x

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2748

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org,
                   |                            |dtucker at zip.com.au
   Attachment #3018|                            |ok?(djm at mindrot.org)
              Flags|                            |

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
Created attachment 3018
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3018&action=edit
Require exact match or dots for older WinSCP versions.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2748

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2698

--- Comment #2 from Darren Tucker <dtucker at zip.com.au> ---
(In reply to Martin Prikryl from comment #0)
> 		  "WinSCP_release_5.0,"
> 		  "WinSCP_release_5.0.*,"
That one looks unnecessary unless you have versions numbers with
leading zeros (which it seems you don't).


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2698
[Bug 2698] Tracking bug for OpenSSH 7.6 release
-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2748

--- Comment #3 from Darren Tucker <dtucker at zip.com.au> ---
Could you please confirm the patch does what you want?  Thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2748

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #3018|ok?(djm at mindrot.org)        |ok+
              Flags|                            |

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2748

--- Comment #4 from Martin Prikryl <martin at winscp.net> ---
(In reply to Darren Tucker from comment #2)
> (In reply to Martin Prikryl from comment #0)
> > 		  "WinSCP_release_5.0,"
> > 		  "WinSCP_release_5.0.*,"
> 
> That one looks unnecessary unless you have versions numbers with
> leading zeros (which it seems you don't).
True. I've added it just for consistency.

(In reply to Darren Tucker from comment #3)
> Could you please confirm the patch does what you want?  Thanks.
There should be a dot, not comma after 1:
"WinSCP_release_5.1,*,"
Like this:
"WinSCP_release_5.1.*,"

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2748

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Darren Tucker <dtucker at zip.com.au> ---
(In reply to Martin Prikryl from comment #4)
[...]
> There should be a dot, not comma after 1:
> "WinSCP_release_5.1,*,"
> Like this:
> "WinSCP_release_5.1.*,"
Fixed.

Patch applied and will be in 7.6.  Thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2748

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.