bugzilla-daemon at bugzilla.mindrot.org
2017-Jan-15 01:13 UTC
[Bug 2664] New: Boolean option parsing is excessively case-sensitive
https://bugzilla.mindrot.org/show_bug.cgi?id=2664
Bug ID: 2664
Summary: Boolean option parsing is excessively case-sensitive
Product: Portable OpenSSH
Version: 7.4p1
Hardware: Other
URL: https://bugs.launchpad.net/bugs/1656557
OS: Linux
Status: NEW
Severity: enhancement
Priority: P5
Component: sshd
Assignee: unassigned-bugs at mindrot.org
Reporter: cjwatson at debian.org
The pure yes/no options in sshd that are handled by parse_flag are
case-sensitive. For example, "PasswordAuthentication yes" is accepted
while "PasswordAuthentication Yes" is not. This seems unnecessarily
picky, since the meaning is unambiguous and it's an easy mistake for
users to make. It's also at variance with (1) all the options handled
by parse_multistate in servconf.c and (2) the corresponding code in
readconf.c to handle client options, both of which use strcasecmp.
I'd suggest that it would make sense to make the handling in servconf.c
work the same way as that in readconf.c, where parse_flag just sets
multistate_ptr = multistate_flag and falls through to parse_multistate;
the code would even be shorter as a result.
--
You are receiving this mail because:
You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2017-Nov-03 03:18 UTC
[Bug 2664] Boolean option parsing is excessively case-sensitive
https://bugzilla.mindrot.org/show_bug.cgi?id=2664
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org
CC| |djm at mindrot.org,
| |dtucker at zip.com.au
Attachment #3084| |ok?(dtucker at zip.com.au)
Flags| |
--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Created attachment 3084
--> https://bugzilla.mindrot.org/attachment.cgi?id=3084&action=edit
reuse parse_multistate for servconf.c parse_flag
Fine idea. I love deleting code.
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2017-Nov-03 03:21 UTC
[Bug 2664] Boolean option parsing is excessively case-sensitive
https://bugzilla.mindrot.org/show_bug.cgi?id=2664
Darren Tucker <dtucker at zip.com.au> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3084|ok?(dtucker at zip.com.au) |ok+
Flags| |
--
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.
bugzilla-daemon at bugzilla.mindrot.org
2017-Nov-03 05:17 UTC
[Bug 2664] Boolean option parsing is excessively case-sensitive
https://bugzilla.mindrot.org/show_bug.cgi?id=2664
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |2782
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Committed - this will be in OpenSSH 7.7
Referenced Bugs:
https://bugzilla.mindrot.org/show_bug.cgi?id=2782
[Bug 2782] Tracking bug for OpenSSH 7.7 release
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.
bugzilla-daemon at mindrot.org
2021-Apr-23 05:00 UTC
[Bug 2664] Boolean option parsing is excessively case-sensitive
https://bugzilla.mindrot.org/show_bug.cgi?id=2664
Damien Miller <djm at mindrot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #3 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release
--
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.