openssh bugs - Oct 2016 - [Bug 2623] New: AuthorizedKeysFile split pub key and signature with tab `\t` not work.

https://bugzilla.mindrot.org/show_bug.cgi?id=2623

            Bug ID: 2623
           Summary: AuthorizedKeysFile split pub key and signature with
                    tab `\t` not work.
           Product: Portable OpenSSH
           Version: 7.3p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: sshd
          Assignee: unassigned-bugs at mindrot.org
          Reporter: mhohai at aim.com

I split pub key and signature with \t, it's not working..

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2623

--- Comment #1 from gshmu <mhohai at aim.com> ---
command at ubuntu# grep "AuthorizedKeysFile" /etc/ssh/sshd_config 
AuthorizedKeysFile %h/.ssh/me.pro

not using default authorized_keys file, after upgrade it not work...

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2623

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au

--- Comment #2 from Darren Tucker <dtucker at zip.com.au> ---
You put a tab in the authorized_keys file itself or after the directive
in sshd_config?

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2623

--- Comment #3 from gshmu <mhohai at aim.com> ---
(In reply to Darren Tucker from comment #2)
> You put a tab in the authorized_keys file itself or after the
> directive in sshd_config?
authorized_keys file itself

$ cat .ssh/authorized_keys_renamed
xxxx{\tab}sign
xxxx{\tab}sign
xxxx{\tab}sign

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2623

--- Comment #4 from Darren Tucker <dtucker at zip.com.au> ---
Created attachment 2878
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2878&action=edit
Allow a single tab instead of space between key type and key.

Looks like the code in question is in sshkey.c:sshkey_read(), and that
tabs are accepted in many places but not all.  In that code's defense,
the sshd(8) man page specifies that these things are space-separated.

        case KEY_UNSPEC:
[...]
                space = strchr(cp, ' ');
... but later:
                        while (*space == ' ' || *space == '\t')
                                space++;

Please try the attached patch, which should allow a single tab
character instead of a space.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2623

--- Comment #5 from Darren Tucker <dtucker at zip.com.au> ---
(In reply to Darren Tucker from comment #4)
> Created attachment 2878 [details]
> Allow a single tab instead of space between key type and key.
Looks like this causes a regression test failure so further
investigation is needed.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2623

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |calestyo at scientia.net

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
*** Bug 2294 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.