openssh bugs - Mar 2016 - [Bug 2559] New: Warnings from reading moduli file, refer to primes file

https://bugzilla.mindrot.org/show_bug.cgi?id=2559

            Bug ID: 2559
           Summary: Warnings from reading moduli file, refer to primes
                    file
           Product: Portable OpenSSH
           Version: 7.2p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: sshd
          Assignee: unassigned-bugs at mindrot.org
          Reporter: xnox at ubuntu.com

Created attachment 2801
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2801&action=edit
moduli-primes-warnings.patch

Warnings about lack of moduli & primes files, refer to primes location
only. Ditto, failing to find suitable prime in "moduli" file emits a
warning that "no suitable primes" in "primes" file.

Attached patch keeps track of which file was opened moduli or primes,
and correctly emits appropriate warnings.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2559

Christian Kujau <mindrot at nerdbynature.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mindrot at nerdbynature.de

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2559

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2543
           Assignee|unassigned-bugs at mindrot.org |dtucker at zip.com.au
                 CC|                            |dtucker at zip.com.au
             Status|NEW                         |ASSIGNED

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
diff looks ok, however the "primes" file was deprecated in 2001:

$ cvs log dh.c
[...]
revision 1.15
date: 2001/06/22 21:27:07;  author: provos;  state: Exp;  lines: +4 -4;
use /etc/moduli instead of /etc/primes, okay markus@

so I suspect we'd be better off just removing the fallback.  If you
haven't updated in 15 years then logging a warning and falling back to
the built-in groups is the least of your problems.

While there:
 logit("WARNING: %s does not exist, using fixed modulus",
moduli_path);

While being missing is the most likely reason the open failed, it's not
the only one.  While we're making it more accurate we should include
the real reason too.


Referenced Bugs:

https://bugzilla.mindrot.org/show_bug.cgi?id=2543
[Bug 2543] Tracking bug for OpenSSH 7.3 release
-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2559

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2801|0                           |1
        is obsolete|                            |
                 CC|                            |djm at mindrot.org
   Attachment #2802|                            |ok?(djm at mindrot.org)
              Flags|                            |

--- Comment #2 from Darren Tucker <dtucker at zip.com.au> ---
Created attachment 2802
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2802&action=edit
Remove /etc/primes fallback and fix moduli log messages

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2559

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Darren Tucker <dtucker at zip.com.au> ---
patch applied and will be in 7.3.  Thanks.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2559

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after 7.3p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2559

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2802|ok?(djm at mindrot.org)        |
              Flags|                            |

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.