openssh bugs - May 2015 - [Bug 2402] New: Missing include in kex.h results in compilation error due to unknown type

https://bugzilla.mindrot.org/show_bug.cgi?id=2402

            Bug ID: 2402
           Summary: Missing include in kex.h results in compilation error
                    due to unknown type
           Product: Portable OpenSSH
           Version: 6.8p1
          Hardware: Sparc
                OS: Solaris
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Kerberos support
          Assignee: unassigned-bugs at mindrot.org
          Reporter: tomas.kuthan at oracle.com

#include <signal.h> has been removed from kex.h.

On Solaris, this causes a compilation error due to sig_atomic_t type
being undefined.

/usr/gcc/4.7/bin/gcc -m64 -O3  -DSET_USE_PAM -DDEPRECATE_SUNSSH_OPT
-DKRB5_BUILD_FIX -DDTRACE_SFTP -DDISABLE_BANNER -DPAM_ENHANCEMENT
-DPAM_BUGFIX -DOPTION_DEFAULT_VALUE -DWITHOUT_ED25519 -Wall
-Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security
-Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing
-D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -fstack-protector-all 
-I. -I/builds2/tkuthan/ul-ssh6_8/components/openssh/openssh-6.8p1 
-I/usr/include/editline   -I/usr/include/kerberosv5 -I/usr/include
-DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\"
-D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/lib/ssh/ssh-askpass\"
-D_PATH_SFTP_SERVER=\"/usr/lib/ssh/sftp-server\"
-D_PATH_SSH_KEY_SIGN=\"/usr/lib/ssh/ssh-keysign\"
-D_PATH_SSH_PKCS11_HELPER=\"/usr/lib/ssh/ssh-pkcs11-helper\"
-D_PATH_SSH_PIDDIR=\"/var/run\"
-D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c
/builds2/tkuthan/ul-ssh6_8/components/openssh/openssh-6.8p1/gss-genr.c
-o gss-genr.o
In file included from
/builds2/tkuthan/ul-ssh6_8/components/openssh/openssh-6.8p1/gss-genr.c:45:0:
/builds2/tkuthan/ul-ssh6_8/components/openssh/openssh-6.8p1/kex.h:147:2:
error: unknown type name 'sig_atomic_t'
make[1]: *** [gss-genr.o] Error

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2402

--- Comment #1 from Tomas Kuthan <tomas.kuthan at oracle.com> ---
Created attachment 2625
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2625&action=edit
Simple patch reverting removal of the include statement.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2402

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2625|0                           |1
        is obsolete|                            |
                 CC|                            |dtucker at zip.com.au

--- Comment #2 from Darren Tucker <dtucker at zip.com.au> ---
Created attachment 2626
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2626&action=edit
including signal.h in gss-genr.c

For the most part we are trying to have things included in the source
file where it's needed rather than have headers include other headers. 
Does this fix it?

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2402

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2360

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2402

--- Comment #3 from Tomas Kuthan <tomas.kuthan at oracle.com> ---
Yes, that works fine too.
(That, plus fixing GSS-API key exchange sources, but that is a
different story.)

Thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2402

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Darren Tucker <dtucker at zip.com.au> ---
thanks.  patch applied and will be in the 6.9p1 release.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2402

--- Comment #5 from Tomas Kuthan <tomas.kuthan at oracle.com> ---
Great! Thank you.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2402

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after 7.3p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.