openssh bugs - Sep 2014 - [Bug 2278] New: 'configure --disable-lastlog' should mark PrintLastLog as unsupported in servconf.c

https://bugzilla.mindrot.org/show_bug.cgi?id=2278

            Bug ID: 2278
           Summary: 'configure --disable-lastlog' should mark
PrintLastLog
                    as unsupported in servconf.c
           Product: Portable OpenSSH
           Version: 6.6p1
          Hardware: All
                OS: Solaris
            Status: NEW
          Severity: minor
          Priority: P5
         Component: sshd
          Assignee: unassigned-bugs at mindrot.org
          Reporter: brent.paulson at gmail.com

Created attachment 2476
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2476&action=edit
mark PrintLastLog as unsupported if DISABLE_LASTLOG is true

It is possible to disable all lastlog references in OpenSSH by using
the
following configure option:

  --disable-lastlog       disable use of lastlog even if detected

This also has the side-effect of removing support for the
'PrintLastLog'
sshd_config(8) keyword although it is still parsed and processed in
servconf.c as if it were possible to change.  The sshd_config(8) man
page describes the PrintLastLog option as:

     PrintLastLog
          Specifies whether sshd(1M) should print  the  date  and
          time  of  the  last  user  login  when  a  user logs in
          interactively.  The default is ``yes''.

Thus, in line with other sshd_config(8) keywords which are no longer
available when the associated functionality is disabled I'd like to
propose patching servconf.c to mark 'printlastlog' as unsupported if
DISABLE_LASTLOG is set.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2278

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2266
                 CC|                            |djm at mindrot.org

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
applied - thanks!

commit 5a1284bba78f51d09c6f6a7cdec60a7584d55263
Author: Damien Miller <djm at google.com>
Date:   Thu Dec 18 17:43:04 2014 +1100

    turn off PrintLastLog when --disable-lastlog

    bz#2278 from Brent Paulson

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2278

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2278

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
openssh-6.8 is released

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2278

Tomas Kuthan <tomas.kuthan at oracle.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomas.kuthan at oracle.com

--- Comment #3 from Tomas Kuthan <tomas.kuthan at oracle.com> ---
That's weird: referenced commit
5a1284bba78f51d09c6f6a7cdec60a7584d55263 does not exist on github and
the patch is not applied to HEAD nor 6.8p1.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2278

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Not sure what happened there - I've reapplied the patch and it will be
in openssh-7.2

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.