openssh bugs - Feb 2015 - [Bug 2352] New: also look for host-prefixed ar, to avoid using ie /usr/bin/ar when cross compiling

https://bugzilla.mindrot.org/show_bug.cgi?id=2352

            Bug ID: 2352
           Summary: also look for host-prefixed ar, to avoid using ie
                    /usr/bin/ar when cross compiling
           Product: Portable OpenSSH
           Version: -current
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Build system
          Assignee: unassigned-bugs at mindrot.org
          Reporter: astrand at lysator.liu.se

It seems like this patch:

http://lists.mindrot.org/pipermail/openssh-unix-dev/2013-September/031646.html

...was never accepted. If there are no good reasons to object it,
please apply.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2352

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |2360
                 CC|                            |dtucker at zip.com.au

--- Comment #1 from Darren Tucker <dtucker at zip.com.au> ---
The proposed change to configure.ac is:

-AC_PATH_PROG([AR], [ar])
+AC_CHECK_TOOLS([AR], [ar])

The autoconf man page says:

"Like AC_CHECK_PROG, but first looks for prog-to-check-for with a
prefix of the host type as specified by --host, followed by a dash."

compared to AC_PATH_PROG which says:

"Like AC_CHECK_PROG, but set variable to the absolute name of
prog-to-check-for if found. The result of this test can be overridden
by setting the variable variable. A positive result of this test is
cached in the ac_cv_path_variable variable."

I think we just use AR in the Makefile so I don't see a reason it could
not be changed.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2352

--- Comment #2 from Darren Tucker <dtucker at zip.com.au> ---
comparing the output of configure before and after the proposed change
shows

-checking for ar... /usr/bin/ar
+checking for ar... ar

and a similar change in Makefile.

Some of the other tools (notably the compiler) are not referenced by
full path so I guess we're not adding any new dependencies on $PATH.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2352

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Darren Tucker <dtucker at zip.com.au> ---
Patch applied and will be in 6.9p1.

Thanks!

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2352

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after 7.3p1 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.