openssh bugs - Oct 2014 - [Bug 2285] New: Say NOT updated instead of updated

https://bugzilla.mindrot.org/show_bug.cgi?id=2285

            Bug ID: 2285
           Summary: Say NOT updated instead of updated
           Product: Portable OpenSSH
           Version: 6.6p1
          Hardware: Other
               URL: http://bugs.debian.org/764269
                OS: Linux
            Status: NEW
          Severity: trivial
          Priority: P5
         Component: ssh-keygen
          Assignee: unassigned-bugs at mindrot.org
          Reporter: jidanni at jidanni.org

We observe that aside from the first run below,
the message "/home/jidanni/.ssh/known_hosts updated." is incorrect.
Using diff(1) we show that the contents remain the same.
Therefore in the latter cases, saying
"/home/jidanni/.ssh/known_hosts NOT updated."
would be better. Nor is there any reason to write a backup.

$ ssh-keygen -f "/home/jidanni/.ssh/known_hosts" -R m.jidanni.org
# Host m.jidanni.org found: line 2 type RSA
/home/jidanni/.ssh/known_hosts updated.
Original contents retained as /home/jidanni/.ssh/known_hosts.old
$ ssh-keygen -f "/home/jidanni/.ssh/known_hosts" -R m.jidanni.org
/home/jidanni/.ssh/known_hosts updated.
Original contents retained as /home/jidanni/.ssh/known_hosts.old
$ ssh-keygen -f "/home/jidanni/.ssh/known_hosts" -R m.jidanni.org
/home/jidanni/.ssh/known_hosts updated.
Original contents retained as /home/jidanni/.ssh/known_hosts.old
$ diff /home/jidanni/.ssh/known_hosts.old
/home/jidanni/.ssh/known_hosts
$

Yes you might think it odd that a user would repeat the command by
accident perhaps, but even more odd are the incorrect messages.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2285

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
This was fixed in openssh-6.8 by another change:

$ ./ssh-keygen -R test.example.com
# Host test.example.com found: line 157
home/djm/.ssh/known_hosts updated.
Original contents retained as /home/djm/.ssh/known_hosts.old
$ rm -f /home/djm/.ssh/known_hosts.old
$ ./ssh-keygen -R test.example.com
Host test.example.com not found in home/djm/.ssh/known_hosts
$ ls -l /home/djm/.ssh/known_hosts.old
ls: cannot access /home/djm/.ssh/known_hosts.old: No such file or
directory

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2285

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.