openssh bugs - Feb 2014 - [Bug 2200] New: ssh -W causes "getsockname failed: Bad file descriptor" errors

https://bugzilla.mindrot.org/show_bug.cgi?id=2200

            Bug ID: 2200
           Summary: ssh -W causes "getsockname failed: Bad file
                    descriptor" errors
           Product: Portable OpenSSH
           Version: 6.5p1
          Hardware: All
               URL: http://bugs.debian.org/738693
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: cjwatson at debian.org

Marco d'Itri reports in http://bugs.debian.org/738693 that "ssh
-W" has
started causing "getsockname failed: Bad file descriptor" errors;
these
are new in 6.5p1 and reported via error().  I think this was triggered
by the new calls to get_sock_port from port_open_helper in
https://anongit.mindrot.org/openssh.git/commit/?id=4def184; gdb shows
that c->sock is -1 here.

Full -vvv output in the Debian bug; relevant-looking excerpt:

debug3: ssh_init_stdio_forwarding: server2.example.net:22
debug1: channel_connect_stdio_fwd server2.example.net:22
debug1: channel 0: new [stdio-forward]
debug2: fd 4 setting O_NONBLOCK
debug3: fd 5 is O_NONBLOCK
getsockname failed: Bad file descriptor
debug1: getpeername failed: Bad file descriptor

It looks like it still works fine, but the extra non-debug error is
annoying.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2200

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2407|                            |ok?(dtucker at zip.com.au)
              Flags|                            |
                 CC|                            |djm at mindrot.org,
                   |                            |dtucker at zip.com.au
           Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Created attachment 2407
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2407&action=edit
Skip get_sock_port call for c->sock==-1

Thanks for the detailed report as always. This should fix it.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2200

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2407|ok?(dtucker at zip.com.au)     |ok+
              Flags|                            |

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2200

--- Comment #2 from Colin Watson <cjwatson at debian.org> ---
Thanks, that indeed seems to solve the problem here.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2200

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
             Blocks|                            |2188
         Resolution|---                         |FIXED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
applied - thanks.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2200

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Close all bugs left open from 6.6 and 6.7 releases.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.