openssh bugs - Dec 2013 - [Bug 2186] New: ssh-agent crashes when removing PKCS#11 library keys if non-PKCS#11 keys are present

https://bugzilla.mindrot.org/show_bug.cgi?id=2186

            Bug ID: 2186
           Summary: ssh-agent crashes when removing PKCS#11 library keys
                    if non-PKCS#11 keys are present
           Product: Portable OpenSSH
           Version: 6.3p1
          Hardware: All
                OS: Mac OS X
            Status: NEW
          Severity: minor
          Priority: P5
         Component: ssh-agent
          Assignee: unassigned-bugs at mindrot.org
          Reporter: jay at slushpupie.com

Created attachment 2391
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2391&action=edit
openssh-6.3p1-agent.patch

When removing a PKCS#11 key from the agent, the agent crashes if
file-based keys are present in the agent.  I discovered this was
because strcmp() is called on the provider of each key, but the
provider is NULL for file keys.  The attached patch remedies this by
checking for a NULL provider first.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2186

Jay Kline <jay at slushpupie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|Mac OS X                    |All

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2186

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2391|0                           |1
        is obsolete|                            |
   Attachment #2394|                            |ok?(dtucker at zip.com.au)
              Flags|                            |
                 CC|                            |djm at mindrot.org,
                   |                            |dtucker at zip.com.au
           Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Created attachment 2394
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2394&action=edit
tweaked patch

Nice catch - thanks.

I think a comment is in order here (implemented in tweaked patch).

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2186

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2394|ok?(dtucker at zip.com.au)     |ok+
              Flags|                            |

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2186

--- Comment #2 from Jay Kline <jay at slushpupie.com> ---
Does anything else need to be done to get this patch applied?

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2186

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
             Blocks|                            |2188
         Resolution|---                         |FIXED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
oops. This was committed back in December and made it into the 6.5
release, but unfortunately not the release notes.

https://anongit.mindrot.org/openssh.git/commit/?h=V_6_5&id=0b36c83148976c7c8268f4f41497359e2fb26251

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2186

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|2188                        |2130

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
oops, added to wrong tracking bug; should have been 6.5

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2186

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.