openssh bugs - Sep 2013 - [Bug 2151] New: Call to upload_dir() has pflag and printflag swapped

https://bugzilla.mindrot.org/show_bug.cgi?id=2151

            Bug ID: 2151
           Summary: Call to upload_dir() has pflag and printflag swapped
           Product: Portable OpenSSH
           Version: -current
          Hardware: Other
                OS: Other
            Status: NEW
          Severity: trivial
          Priority: P5
         Component: sftp
          Assignee: unassigned-bugs at mindrot.org
          Reporter: imorgan at nas.nasa.gov

Created attachment 2331
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2331&action=edit
Make definition match actual usage.

While working on a patch for sftp(1), I noticed that the pflag and
This seems to have been the case since the initial inclusion in 5.4.

sftp.c-718-             if (!quiet)
sftp.c-719-                     printf("Uploading %s to %s\n",
g.gl_pathv[i], abs_dst);
sftp.c-720-             if (pathname_is_dir(g.gl_pathv[i]) && (rflag ||
global_rflag)) {
sftp.c:721:                     if (upload_dir(conn, g.gl_pathv[i],
abs_dst,
sftp.c-722-                         pflag || global_pflag, 1) == -1)
sftp.c-723-                             err = -1;
sftp.c-724-             } else {
--
sftp-client.c-1643-}
sftp-client.c-1644-
sftp-client.c-1645-int
sftp-client.c:1646:upload_dir(struct sftp_conn *conn, char *src, char
*dst, int printflag,
sftp-client.c-1647-    int pflag)
sftp-client.c-1648-{
sftp-client.c-1649-     char *dst_canon;

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2151

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
             Blocks|                            |2130

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
applied - thanks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2151

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after 7.3p1 release

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.