openssh bugs - Jul 2013 - [Bug 2129] New: [PATCH] sftp chroot regression

https://bugzilla.mindrot.org/show_bug.cgi?id=2129

            Bug ID: 2129
           Summary: [PATCH] sftp chroot regression
           Product: Portable OpenSSH
           Version: 6.2p1
          Hardware: Other
                OS: FreeBSD
            Status: NEW
          Severity: normal
          Priority: P5
         Component: sftp
          Assignee: unassigned-bugs at mindrot.org
          Reporter: delphij at freebsd.org

Created attachment 2319
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2319&action=edit
patch to address sftp chroot symlink issue

I'd like to report a possible regression in sftp(1).  In earlier
OpenSSH versions, when doing 'symlink' over sftp, the system will
create a symbolic link with relative path, and now it creates a
symbolic link with absolute path.  When doing chroot, this would make
an unusable symbolic link.

The behavior change was introduced in OpenBSD src/usr.bin/ssh/sftp.c,v
1.132 and based on my understanding of the commit log, this is not
intentional.

How to reproduce:

# sftp dtest
sftp> symlink ./l1 22
sftp> ^D

# ssh dtest "ls -l 22"
lrwxr-xr-x  1 delphij  delphij  23 Jun 21 17:28 22@ -> /home/delphij/l1

What's expected:

lrwxr-xr-x  1 delphij  delphij  4 Jun 21 17:25 22@ -> ./l1

The attached patch should fix this.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2129

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
            Summary|[PATCH] sftp chroot         |sftp symlink incorrectly
                   |regression                  |makes target path absolute

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2129

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned-bugs at mindrot.org |djm at mindrot.org
   Attachment #2319|0                           |1
        is obsolete|                            |

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
Created attachment 2327
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2327&action=edit
improved patch

That patch is incorrect - it would break hardlinking. This one only
skips the canonicalistion for symlinks.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2129

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
             Blocks|                            |2130

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
patch applied - will be in openssh-6.4

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2129

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Close all resolved bugs after 7.3p1 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.