openssh bugs - Jun 2013 - [Bug 1988] ControlPersist causes stderr to be left open until the master connection times out

https://bugzilla.mindrot.org/show_bug.cgi?id=1988

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
             Blocks|                            |2076

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1988

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2299|                            |ok?(djm at mindrot.org)
              Flags|                            |

--- Comment #5 from Darren Tucker <dtucker at zip.com.au> ---
Created attachment 2299
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2299&action=edit
daemonize backgrounded mux master with controlpersist

please try this patch from tedu: daemon'ize the backgrounded mux
master.

the new -E options should make the logging more useful in this case.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1988

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2299|ok?(djm at mindrot.org)        |ok+
              Flags|                            |

--- Comment #6 from Damien Miller <djm at mindrot.org> ---
Comment on attachment 2299
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2299
daemonize backgrounded mux master with controlpersist
>Index: ssh.c
>==================================================================>RCS
file: /cvs/src/usr.bin/ssh/ssh.c,v
>retrieving revision 1.378
>diff -u -p -r1.378 ssh.c
>--- ssh.c	17 May 2013 00:13:14 -0000	1.378
>+++ ssh.c	6 Jun 2013 01:51:58 -0000
>@@ -947,6 +947,8 @@ control_persist_detach(void)
> 		fatal("%s: fork: %s", __func__, strerror(errno));
> 	case 0:
> 		/* Child: master process continues mainloop */
>+		if (daemon(1, 0) == -1)
>+ 			fatal("Failed to daemonize control master");
I'd prefer this happen in the block after the switch statement, where
the fd cleanup already occurs.

Otherwise ok by me

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.