openssh bugs - Jan 2013 - [Bug 1981] Trying to use ssh with a missing identity file gives no warnings

https://bugzilla.mindrot.org/show_bug.cgi?id=1981

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2136|                            |ok+
              Flags|                            |

--- Comment #4 from Damien Miller <djm at mindrot.org> ---
Comment on attachment 2136
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2136
warn for missing user-provided IdentityFiles

ok djm
>--- sshconnect2.c	29 May 2011 11:42:34 -0000	1.180
>+++ sshconnect2.c	9 Mar 2012 00:02:06 -0000
...
>+		if (userprovided)
>+			logit("no such identity: %s: %s", filename,
>+			    strerror(errno));
>+		else
>+			debug3("no such identity: %s: %s", filename,
>+			    strerror(errno));
I'd probably do this as:

(userprovided ? logit : debug3)("no such identity: %s: %s", filename,
strerror(errno));

but that's just a preference.
>-		debug2("key: %s (%p)", id->filename, id->key);
>+		debug2("key: %s (%p), userprovided %d", id->filename,
id->key,
>+		    id->userprovided);
Maybe %s and (id->userprovided ? " explicit" : "")

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1981

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2219|                            |ok?(djm at mindrot.org)
              Flags|                            |
   Attachment #2136|0                           |1
        is obsolete|                            |

--- Comment #5 from Darren Tucker <dtucker at zip.com.au> ---
Created attachment 2219
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2219&action=edit
updated patch with feedback

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1981

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2219|ok?(djm at mindrot.org)        |ok+
              Flags|                            |

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1981

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Darren Tucker <dtucker at zip.com.au> ---
applied, thanks.  it will be in the 6.2 release.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.