openssh bugs - Mar 2011 - [Bug 1213] ssh-keyscan exits in mid-way

https://bugzilla.mindrot.org/show_bug.cgi?id=1213

aab at purdue.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2008|0                           |1
        is obsolete|                            |

--- Comment #31 from aab at purdue.edu 2011-03-18 17:36:09 EST ---
Created attachment 2016
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2016
Remove a bit of confusion from previous patch.

I guess I'm the one that has an issue with the previous patch.  The
hostkey alg error message always references the "other end" of the
socket.  On the server the message reads as if the client was the one
that didn't have the necessary hostkey algorithms.  The updated patch
has modified verbage for the server that attempts to distnguish the
difference.

I have a general issue with this anyhow.  Wouldn't it be possible to
check the server algorithms BEFORE asking the server to return a key
that it doesn't have.  If I read the code correctly, the
debug2:kex_parse_init messages indicate that the code extracts the list
of algorithms that the server supports from the SSH2_MSG_KEXINIT
response.  Isn't that before the request?  Right now both the server
and the client issue the same abort message and that seems a waste of
time (and log file space (;-})).

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1213

aab at purdue.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2016|0                           |1
        is obsolete|                            |

--- Comment #32 from aab at purdue.edu 2011-03-19 16:38:46 EST ---
Created attachment 2018
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2018
Add 'L' option to usage message

Another small issue.  I forgot to add the new '-L' option to the usage
message.  Also modified some of the comments for clarity.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1213

aab at purdue.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2018|0                           |1
        is obsolete|                            |

--- Comment #33 from aab at purdue.edu 2011-03-26 11:38:20 EST ---
Created attachment 2021
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2021
Withdraw patch attachment #2018.

This missive just obsoletes(withdraws) the current variant of the
patch.  We just had a bad network glitch here and, because of it,
ssh-keyscan called the `select()' function in the `packet_read_seqnr()'
function with a NULL timeout value.  Since the read wasn't going to
receive any data because of the glitch ever, it occasionally did one of
those hang forever thingys.  The patch still works if your network
doesn't glitch like ours did albeit very crudely.

It turns out that the original coders of ssh-keyscan missed(?) a call
to the `packet_set_timeout()' function which in turn caused the above
referenced NULL.  I'm in the process of rewriting the patch to include
a "set" call.

FWIW - bugzilla won't let me subit this withour a non-null file.  The
new attachment is a NL.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.