openssh bugs - Aug 2010 - [Bug 1809] New: ssh-agent doesnt respect $TMPDIR

https://bugzilla.mindrot.org/show_bug.cgi?id=1809

           Summary: ssh-agent doesnt respect $TMPDIR
           Product: Portable OpenSSH
           Version: 5.6p1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ssh-agent
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: vapier at gentoo.org


Created attachment 1913
  --> https://bugzilla.mindrot.org/attachment.cgi?id=1913
openssh-ssh-agent-tmpdir.patch

the ssh-agent program hardcodes the /tmp/ path:
   if (agentsocket == NULL) {
       /* Create private directory for agent socket */
       strlcpy(socket_dir, "/tmp/ssh-XXXXXXXXXX", sizeof socket_dir);

this doesnt respect a user's TMPDIR preference and can obviously break
if /tmp/ is screwed up (full/whatever), but TMPDIR is pointing to a
usable location.

here is an untested patch, but looks straight forward to me :p

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1809

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |1803

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1809

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1913|application/octet-stream    |text/plain
          mime type|                            |
   Attachment #1913|0                           |1
           is patch|                            |

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1809

--- Comment #1 from Damien Miller <djm at mindrot.org> 2010-11-05 11:15:23
EST ---
Created attachment 1947
  --> https://bugzilla.mindrot.org/attachment.cgi?id=1947
/home/djm/ssh-tmpdir.diff

use  everywhere

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1809

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Damien Miller <djm at mindrot.org> 2010-11-21 12:21:45
EST ---
this has been fixed in CVS and will be released in openssh 5.7. Thanks.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1809

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> 2011-01-24 12:33:36
EST ---
Move resolved bugs to CLOSED after 5.7 release

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.