openssh bugs - May 2010 - [Bug 1770] New: circular dependencies prevent building on platforms without strlcpy, vasprintf

https://bugzilla.mindrot.org/show_bug.cgi?id=1770

           Summary: circular dependencies prevent building on platforms
                    without strlcpy, vasprintf
           Product: Portable OpenSSH
           Version: 5.5p1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Build system
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: tgl at sss.pgh.pa.us


Building 5.5p1 on HPUX 10.20 (yeah, it's pretty ancient) fails here:

gcc -o ssh-pkcs11-helper ssh-pkcs11-helper.o ssh-pkcs11.o -L.
-Lopenbsd-compat/ -L/usr/local/ssl-0.9.8n/lib  -lssh -lopenbsd-compat
-lssh -lcrypto -lz -lxnet  -lsec
/usr/ccs/bin/ld: Unsatisfied symbols:
   strlcpy (code)
   vasprintf (code)
collect2: ld returned 1 exit status

The problem here seems to be circular dependencies between libssh and
libopenbsd-compat
(because the latter depends on xstrdup which is defined in the former).
 The link succeeds if I add another instance of -lopenbsd-compat at the
end of the command.  That's a pretty crocky workaround though.  Maybe
xstrdup ought to be moved to libopenbsd-compat?

FWIW, openssh 4.6p1 built successfully on this platform, so the
problem's been introduced since then.  Another possibly useful
datapoint is that ssh-pkcs11-helper is the only executable that
exhibits a problem.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1770

--- Comment #1 from Darren Tucker <dtucker at zip.com.au>  ---
Created attachment 1847
  --> https://bugzilla.mindrot.org/attachment.cgi?id=1847
openssh-pkcs11-helper-link.patch

Only link libssh in once.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1770

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
             Blocks|                            |1708

--- Comment #2 from Darren Tucker <dtucker at zip.com.au>  ---
Looks like the problem is that libssh is linked twice:

$(LD) -o $@ ssh-pkcs11-helper.o ssh-pkcs11.o $(LDFLAGS) -lssh
-lopenbsd-compat -lssh $(LIBS)

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1770

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Darren Tucker <dtucker at zip.com.au>  ---
Nope, I'm wrong.

After discussing it we've decided that fixing it properly is a lot of
work and since it only impacts old or odd platforms (eg embedded) we're
going to take the easy way out.

This has been committed and will be in the next release.  Thanks.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1770

Tom Lane <tgl at sss.pgh.pa.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #4 from Tom Lane <tgl at sss.pgh.pa.us>  ---
Sorry, that proposed patch does *not* fix it.  When I do that I get

/usr/ccs/bin/ld: Unsatisfied symbols:
   xstrdup (code)

You really do have a circular dependency here, and the only way to make
it work with just rejiggering the link line is to mention both
libraries twice.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1770

--- Comment #5 from Darren Tucker <dtucker at zip.com.au>  ---
Created attachment 1882
  --> https://bugzilla.mindrot.org/attachment.cgi?id=1882
openssh-bug1770.patch

Link against libraries twice (this is what was committed).

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1770

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Darren Tucker <dtucker at zip.com.au>  ---
Sorry, it wasn't clear from the bug history but that's exactly what we
ended up doing (list both libraries twice).  I have attached the patch
that was committed.

If it's still broken in the current snapshots
(http://mindrot.org/openssh_snap/) then please reopen.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1770

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1847|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1770

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Damien Miller <djm at mindrot.org> 2011-01-24 12:34:01
EST ---
Move resolved bugs to CLOSED after 5.7 release

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.