openssh bugs - Mar 2010 - [Bug 1742] New: sshconnect should use port returned by getaddrinfo

https://bugzilla.mindrot.org/show_bug.cgi?id=1742

           Summary: sshconnect should use port returned by getaddrinfo
           Product: Portable OpenSSH
           Version: 5.4p1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: ssh
        AssignedTo: unassigned-bugs at mindrot.org
        ReportedBy: rees at merit.edu


Created an attachment (id=1820)
 --> (https://bugzilla.mindrot.org/attachment.cgi?id=1820)
use getaddrinfo for sshd port lookup

Ssh, in ssh_connect(), calls getaddrinfo() to get the the server
endpoint address. Getaddrinfo returns a port number but this is
ignored. Ssh instead makes an unnecessary call to getservbyname() to
get the port number. In most cases this makes no difference, but this
makes it impossible to use DNS SRV records to find ssh services.

The attached patch eliminates the call to getservbyname and instead
uses the port returned by getaddrinfo.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1742

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
             Blocks|                            |1708

--- Comment #1 from Damien Miller <djm at mindrot.org> 2010-04-09 11:12:23
EST ---
We need to be careful here, I think the port number that we obtain by
getservbyname() is used to decide whether to decorate the hostname with
a non default port in known_hosts.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1742

--- Comment #2 from Damien Miller <djm at mindrot.org>  ---
We are freezing for the OpenSSH 5.6 release. Retargetting these bugs to
the next release.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1742

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1803

--- Comment #3 from Damien Miller <djm at mindrot.org>  ---
Targetting OpenSSH 5.7

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1742

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|1708                        |

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1742

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|1803                        |1845

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1742

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1930

--- Comment #4 from Damien Miller <djm at mindrot.org> 2011-09-06 10:34:18
EST ---
Retarget unresolved bugs/features to 6.0 release

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1742

--- Comment #5 from Damien Miller <djm at mindrot.org> 2011-09-06 10:36:31
EST ---
Retarget unresolved bugs/features to 6.0 release

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1742

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|1845                        |

--- Comment #6 from Damien Miller <djm at mindrot.org> 2011-09-06 10:39:06
EST ---
Retarget unresolved bugs/features to 6.0 release

(try again - bugzilla's "change several" isn't)

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1742

--- Comment #7 from Jim Rees <rees at merit.edu> 2011-09-06 11:03:36 EST
---
I believe that if there is no SRV record, getaddrinfo will return the
same port as getservbyname. I can check on this. If that's the case,
the risk seems low.

The question is, if there is a SRV record, and it returns something
different from what getservbyname does, what port should be used for
known_hosts? If we can decide on the correct behavior, I can make sure
the patch does the right thing.

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1742

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1986

--- Comment #8 from Damien Miller <djm at mindrot.org> 2012-02-24 10:34:26
EST ---
Retarget from 6.0 to 6.1

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=1742

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|1930                        |

--- Comment #9 from Damien Miller <djm at mindrot.org> 2012-02-24 10:38:06
EST ---
Retarget 6.0 => 6.1

-- 
Configure bugmail: https://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.